supergeroy / sage Goto Github PK

Constants _whiteHashes and _blackHashes (declared in Piece.swift) should be renamed globally into something like whiteRawValues or similar.

There are a few places where the hashable needs to be updated for swift 4.2.

Move.swift:123:16: 'Hashable.hashValue' is deprecated as a protocol requirement; conform type 'Move' to 'Hashable' by implementing 'hash(into:)' instead

The Bitboard struct uses the deprecated BitwiseOperations protocol (see line 562 of Bitboard.swift).
As support for Swift 3 will be removed in XCode 10.2 I need some help in replacing the protocol.
XCode suggests using the FixedWidthInteger protocol instead but I think we only need the BinaryInteger protocol.

For this to work, we need to implement typealiases for Words and Magnitude and here I am struggling at the moment. I will try to find the solution for Sage to continue to work with XCode 10.2 and Swift 4.
Requirement for typealias Magnitude comes from protocol Numeric.
(Currently, I tend to use UInt64 as typealias.)