superzackx / voiceactivatedbots

An attempt to make bots.

👋 Hi, I’m Yash Bhatnagar

• 👀 I’m passionate about programming, football and gaming.
• 🌱 I’m currently learning solidity and smart contracts.
• 📫 Shoot me an email at [email protected].

🛠 Tech Stack

                   

⚙️ GitHub Stats

voiceactivatedbots's Issues

Async callbacks throw errors

This is when we started OOP specifically in the 2nd latest commit. The async callbacks is equivalent to hell in javascript.
The way to fix this issue is to redesign how the model class works.

Through my testing folder I figured out that FS loads even the tests, that is when I figured out this bug. Read this article for more information on the same issue: https://blog.risingstack.com/node-js-async-best-practices-avoiding-callback-hell-node-js-at-scale/

That shows how async callbacks work, all async methods return Promise, I highly recommend installing the JS code snippets for VS Code.

To fix this we can't have any normal functions which don't return promises. That means we have to replace all functions with async and await.

Then we should not be getting into errors, we also should upload in a testing folder so that we don't actually mess something else up. The model class is just an abstract class pretty much because we can use that model to have child classes and then get some prebuilt methods! So please don't edit the model class!

OOP when?

We all know that for a bot and if your planning to make many of them. You would obviously need to categorize them into a separate data type (classes).

Your functions look nice, why don't you just make a class called "Bot" and then put all the functions into methods, by using this method you can easily reuse your code by polymorphism!

Then you can make bots easier, secondly can you please make this into an NPM package so that people can download it with npm rather than git?

Scopes

Variable Scopes

I hope you know that in Vanilla Javascript, the var keyword is at local scope. Inside of functions using vars is just silly because you don't want it in other parts of your code. Using the let keyword inside your functions would be better.

Also inside functions you would not need any arguments if you replace var with const. That way it would be cleaner and better for people like me to read. (I am not the best at JS, but heres a suggestion)

Thanks and Regards,
NightZan999