sustainablecomputinglab / solar-tk Goto Github PK

Since you change the start time and end time to UTC timezone before running get_sun_position(). Do you have to change them back after getting the sun position? It seems like in the implementation of get_sun_position(), you do not change the time back to current time zone.

Hi,

I have some problems to install SolarTK using pip+git. I think the major problem is that your setup.py tries to read README.rst instead of README.md. If you interested, I can open a PR with a fix if you prefer to fix that by yourself, you can take a look at my fork

This enables to install solarTK with pip install git+https://github.com/sustainablecomputinglab/solar-tk and call it more easily from own scripts.

Let me start by saying thank you for sharing!

I was experimenting a little with this project with the AusGrid solar dataset. I seem to run into an issue in the get_tilt function. It seems like southern hemisphere latitudes cause some issues (for example, -33.7085861, 151.1228434).. or at least the negative tilt fails validation in the maximum_generation module. Grateful for any suggestions or advice.

Dear Noman Bashir,

first of all I'd like to congratulate you for the work done with SOLAR-TK.

I would like to kindly as a question about the API keys that the code seems to request.

When I run the code I get the following error message raises: ValueError ("Invalid API key provided."). This is becausa I did not insert an API key and I have to insert it in the parameters.py module. The question is: do I have to insert both the google API key and DarkSky API Key ? If I am right, DarkSky app doesn't exist anymore: does the code run despite this issue ?

Thank you for your attention !

Best regards.

Paolo Vitulli

In parameter estimation, 0.18 is used as the value of efficiency factor.

However, when the estimated k is applied to estimate maximum generation, the efficiency change to 0.2.

Is there any reason for choosing different efficiency value?