swiffty-bot / cli Goto Github PK

There's still all kinds of regex syntax that is not covered by the gitignore parser thingy.

Pretty much every major build tool automatically overwrites existing build automatically. Consider either removing the prompt or only enforcing it if some "prompt on overwrite" flag is provided.

Also, minimizing the amount of secondary prompts will make it easier for people to make workflows to automatically build and publish things. The standard for this when a yes/no prompt is necessary is to add an optional --yes flag (alias -y) that skips the prompt,

Using something like --allow-dirty to skip the git checking latest commit step will allow people who know what they are doing to use the command with uncommitted changes.

Also, allowing dirty should probably be the default for the build command but not the publish command unless we are having the user manually upload zips.

By using a serde Deserialize struct, you can enforce the manifest without writing a ton of code that could easily break if anything is changed or a new field is added. More secure and less lines of code to write.

type annotations needed for `(Vec<&Path>, Vec<_>) at line 77 as ignore_dirs

line 132 at entry?;
line 134 at path.strip_prefix(&current_dir)?;

`?` couldn't convert the error to `std::io::Error`
the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait
the following other types implement trait `From<T>`:
  <std::io::Error as From<anstyle_wincon::windows::inner::IoError>>
  <std::io::Error as From<tempfile::file::PersistError<F>>>
  <std::io::Error as From<walkdir::error::Error>>
  <std::io::Error as From<bzip2::mem::Error>>
  <std::io::Error as From<tempfile::file::PathPersistError>>
  <std::io::Error as From<ZipError>>
  <std::io::Error as From<flate2::mem::DecompressError>>
  <std::io::Error as From<flate2::mem::CompressError>>
and 3 others