swsnr / gethostname.rs Goto Github PK

Full build log:
build.log

Any chance to fix this? Thank you.

Hi there

I'm buidling a crate that has gethostname as one of its nested dependencies. Unfortunately, the crate doesn't compile on wasm32 because gethostname_impl() isn't implemented outside of #[cfg(windows)] and #[cfg(unix)].

Would you be fine if I make a PR to create a stub for wasm and bump versions for you to release on crates.io? This would be for 0.2, 0.3 and 0.4.

The stub would probably be something like:

#[cfg(target_arch = "wasm32")]
fn gethostname_impl() -> OsString {
    OsString::new()
}

Or alternatively I could catch all targets

#[cfg(not(any(windows, unix)))]
fn gethostname_impl() -> OsString {
    unimplemented!(
        "Getting a hostname currently unsupported on your target.
    Please report an issue to <https://github.com/swsnr/gethostname.rs/issues>!")
}