GithubHelp home page GithubHelp logo

swpp18-team11's People

Contributors

algy avatar hintyu avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

swpp18-team11's Issues

Feedback from team 8

my-cart.component.ts: 각 함수의 끝에 newline이 있는 것도 있고 아닌 것도 있습니다.
payment.component.ts: 50번 Line에 calcel() 함수가 있는데 아마 이름이 오타인 것 같습니다.

Purchasable's options not saved in specify-option page

specify-order page에서 select-order component를 사용하지 않고 단품만 my cart에 넣는 경우 option이 null이 되면서 이후 my-cart page에서 option 가격이 NaN이 되는 현상이 발생.
select-order component를 사용했을 때는 option들이 제대로 저장되는 걸로 보아 specify-order page에 약간 문제가 있는 듯. 수정하겠습니다

Code Review from Team 6

  1. [FrontEnd]component의 property는 camel case, class의 변수명은 snake case로 설정하여 일관성을 유지한 것 같습니다.
  2. [FrontEnd] service 파일들이 많아, service 폴더를 만들어서 정리하는 것도 좋은 생각일 것 같습니다.
  3. [BackEnd] models 폴더를 만들어서 기능별로 따로 파일을 만들어 전체적인 구조 파악에 용이했습니다.

전체적으로 배울 점이 많아서 많은 도움이 되었습니다 :)

Frontend test coverage up

  • select-store-franchise.component.ts
  • select-store-map.component.ts
  • manage-order-state.service.ts
  • store.service.ts
  • tx-item.ts
  • user.service.ts

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.