sylvainjule / kirby-footnotes Goto Github PK

Thanks for this great plugin!
I was just giving it a try with the new blocks. And while I can get it to work within one block like so

<?php foreach ($page->thesis()->toBlocks() as $block): ?>

  <?php if ($block->type() == "text" || $block->type() == "markdown"): ?>
    <?= $block->text()->footnotes() ?>
  <?php else: ?>
    <?= $block  ?>
  <?php endif ?>

<?php endforeach ?>

it restarts the numbering of the footnotes with each block anew. That means I will have a footnote numbering like 1, 2, 3, 1, 2, 1, 2 etc. when I use more than one block.

It would be nice, if there would be an easy way to continue the numbering from the previous block.

Hello Sylvain,
Great plugin!

I have a bug as the footnotes are being rendered but the number of each is nor added to the LI( 1,23 etc) :

Identical footnotes lead to an issue with footnote references: all references are numbered with the num of the first occurrence.

Output is blank when text has no notes

First of all: Thank you for this wonderful plugin! And the fix to use it within blocks!

Now: Having square brackets [ inside a footnote breaks the footnote. Which makes sense, because the regex looking out for footnotes found a ] and thus ends the footnote.

On the other hand: It is not unusual to have square brackets inside a footnote, e.g. [...] or to indicate that the editor changed the exact wording of some source, resulting in something like [^Footnote [...] text].

I think, the regex that looks out for [^ should only end a footnote, when it finds a ] AND in the meantime has found as many closing brackets as opening brackets it might have found in between. So after [^...[ the footnote only ends on the second ] it finds...

Thank you four considering.