`Stringable` polyfill has no return type, breaks tests and static analysis about polyfill

[stof]

PHP 8.0 also introduces an internal mechanism that automatically adds the string return type to __toString because this magic method was already strict in earlier versions.
This is why the Stringable polyfill has been implemented without an explicit return type to allow writing code compatible with more PHP versions.

[stof]

Note that the Stringable class from the polyfill is only loaded on PHP 7.x and older. On PHP 8.0+, the native implementation is the one being used anyway.

[lkrms]

PHP 8.0 also introduces an internal mechanism that automatically adds the string return type to __toString because this magic method was already strict in earlier versions. This is why the Stringable polyfill has been implemented without an explicit return type to allow writing code compatible with more PHP versions.

Interesting. This behaviour isn't covered in the documentation for Stringable, but it checks out. Yay for undocumented internal mechanisms 🎉 /s

Note that the Stringable class from the polyfill is only loaded on PHP 7.x and older. On PHP 8.0+, the native implementation is the one being used anyway.

Yes, sorry, I should have mentioned the issue only surfaces on PHP 7.x.

[derrabus]

PHP 8.0 introduced Stringable::__toString() with a return type of string that's enforced at runtime

No, it is not: https://3v4l.org/UpafS

This causes tests and static analysis of Stringable implementations with no __toString() return type to succeed

Which is exactly how that interface behaves on PHP 8. Our polyfill must not be more strict than the real implementation. And even if we did, your static analysis issues would resurface once you upgrade to PHP 8.

Your static analysis issue is 100% home made.