tableau / tableau-ui Goto Github PK

e.g. the Button component supports a dark variant but he Tabs one does not.

Courtney Agerter requests read permission for the People Operations Project in the HR server.

Slider and Toggle are mentioned in the extension-api UX Guidelines these look great and it would be amazing if we could just use them like any of the other components. Sliders might be tricky but the toggle should be relatively simple to implement...

What I mean by Section is a little bit more tricky to explain; in the extension-api UX Guidelines it also mentions how to structure a dialog, having a component to easily build out form sections with a nice header and correct padding and margins would be great. Perhaps this component could also make it easy to line up multiple columns of inputs as shown in some of the images.

I'm passing some values to this component that have multiple spaces in the names but the component is stripping them out.

Eg, passing TEST [insert n number of spaces here] TEST will show the value TEST TEST and pass the incorrect value back through any callbacks/events.

I haven't checked other components for the same issue.

Requested by @tjallingt in #13

It is not included in the bundle that is on npm currently, see: https://unpkg.com/@tableau/[email protected]/lib/src/components/

You can confirm it is actually not in the bundle by going here: https://unpkg.com/@tableau/[email protected]/dist/tableau-ui.min.js and ctrl + f to search for "Pill".

Hi
i was able to create an extension in tableau and i was trying to keep the ui-standard.may i know how can i get the tableau-ui.min.js file so that i can add it in my project?

The "Forum" link in the header of https://tableau.github.io/tableau-ui is not working. When I click it, sometimes I'm taken to a login page, but, whether or not I login, I see an error page. If I try to put https://community.tableau.com/community/developers/ directly in the browser, I see this same error message.

Somehow the typings for this library seem to have broken for various elements (I have only checked the TextField, Button and DropDownselect). "Native" props are seemingly not recognized and cause typescript errors. Unsure when this was introduced.

Example

<TextField value="test" onChange={e => console.log(e.target.value)} />

Type '{ value: string; onChange: (e: any) => void; }' is not assignable to type 'IntrinsicAttributes & TextFieldProps & RefAttributes<HTMLInputElement>'.
  Property 'onChange' does not exist on type 'IntrinsicAttributes & TextFieldProps & RefAttributes<HTMLInputElement>'.ts(2322)

Live examples

https://codesandbox.io/s/1r4x82678q

the DropdownSelect elements in the style guide all have labels but currently in tableau-ui we don't have a prop to add a label.

Originally posted by @tjallingt in #13 (comment)

https://reactjs.org/docs/forwarding-refs.html

React.forwardRef can be applied to "simple" styled components to give developers access to the underlying dom node. Probably useful on Button, Checkbox, DropdownSelect, Pill, Radio and TextField components.

Would be great to have typography components to easily access Tableau's standard fonts/styles for text across titles, informational text, paragraphs, etc.

Requested by @tjallingt in #13

Would be great to have a textarea component. We have users which are adding descriptions and the current is too small for this.

Example code:

<TextField value={0} />

Will display like this:

This happens because of the use of the boolean and operator (&&) which is used to determine whether to display the TextFieldClearButton. This operator will always return either side of the evaluation which in most cases won't matter since React will not render false, undefined, null or "" but unfortunately it will show 0.

This can be replaced by either Boolean(value) && <TextFieldClearButton /> or value ? <TextFieldClearButton /> : null

Requested by @tjallingt in #13