tafia / blpapi-rs Goto Github PK

Hi @tafia, thanks for the work on this crate. I'm going to be using this so hopefully can start contributing some things in the next few weeks.

A small issue to start, I noticed that the *.so *.dll and *.lib in the vendored/ directories are not tracked by LFS and are saved in the repo directly. I fixed this in a local fork but it appears github does not support pushing LFS objects in public forks so unfortunately it means you would have to do it.

In general I find it's better to keep binaries out of the main repo because it causes issues with binary file issues (already had that issue when cloning this repo).

Steps to remove:

• Remove these files from git
• Commit changes
• Add back these files in addition to a .gitattributes file

.gitattributes

# Windows libraries
*.[Dd][Ll][Ll] filter=lfs diff=lfs merge=lfs -text
*.[Ll][Ii][Bb] filter=lfs diff=lfs merge=lfs -text

# Linux libraries
*.[Ss][Oo] filter=lfs diff=lfs merge=lfs -text

This is a meta issue to help me remember all major missing pieces

• Better errors, check relevant elements etc ... (39621c4)
• Don't return HashMap instead return Iterator<Result>. This way it is for the user to decide if it must stop upon error or not. Getting a HashMap would just be about collecting the iterator.
• Async. Wait for rust async-await and see how it could fit.
• Timeouts
• Find a way to store all Names as const (4c4464e)
• Use better pointer wrappers (such as NonNull and MaybeUninit)
• More docs (inline and README)
• More PhantomData?