GithubHelp home page GithubHelp logo

ckeditor_comment's People

Contributors

bdragon28 avatar markhalliwell avatar mmolinari avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ckeditor_comment's Issues

Doesn't work with current version of Rangy

(Usnig Rangy master)

Console: Uncaught TypeError: selection.trim is not a function

editor.widgets.add('comment', {
          defaults: function () {
            var selection = rangy.getSelection(editor.document.$);
            // Attempt to expand word if possible.
            if (selection.isCollapsed) {
              selection.expand('word');
              selection.refresh();
            }
            selection.trim();
            return {
              content: selection.toHtml()
            };
          },

Project continuity

We are adding editorial tools to our Drupal backoffice and (by chance) one of our developers found ckeditor_comments on github. Quickly we tested it, with last ckeditor version, and it works like a charm. However, after looking the code a bit closer, we saw that some features doesn't work while other aren't even coded.

So, I'm wondering if there is a more completed version of this module somewhere or you suspended the development of it for some reason (as I suspect). If this is the case (as I suspect), maybe some guidelines about how to end it or any other documentation about how it was initially designed would be fine!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.