taikoo / bind-geoip Goto Github PK

What steps will reproduce the problem?
1. Attempt to apply patch after modifying PATCHVER & RELEASEVER

What is the expected output? What do you see instead?
Expected output is a clean patch. Instead, it fails on server.c due to changes 
made between 9.9.3-P2 & 9.9.4-P1

What version of the product are you using? On what operating system?
bind-9.9.4-P1 on Debian squeeze

Please provide any additional information below.
The below diff seems to resolve the issue - I can get it to apply clean & 
configure/make on the source succeeds. I haven't actually tested the resulting 
binaries though. I've also attached the modified patch file.

diff bind-geoip-1.3-9.9.4-P1.broke bind-geoip-1.3-9.9.4-P1.patch 
284,285c284,285
< --- bin/named/server.c.orig   2012-09-26 17:35:19.000000000 -0700
< +++ bin/named/server.c        2012-10-09 17:38:10.000000000 -0700

---
> --- bin/named/server.c.orig   2013-10-15 23:04:32.000000000 +0000
> +++ bin/named/server.c        2013-11-18 23:34:29.789421759 +0000
296,297c296,297
< @@ -5297,6 +5300,21 @@
<       return (ISC_R_SUCCESS);

---
> @@ -4859,6 +4862,21 @@
>       return (n);
316,318c316,318
<  load_zones(ns_server_t *server) {
<       isc_result_t result;
< @@ -5443,6 +5461,11 @@

---
>  load_configuration(const char *filename, ns_server_t *server,
>                  isc_boolean_t first_time)
> @@ -5983,6 +6001,11 @@
321c321
<       CHECKFATAL(load_zones(server), "loading zones");

---
>       CHECKFATAL(load_zones(server, ISC_TRUE), "loading zones");
330c330
< @@ -5890,6 +5913,20 @@

---
> @@ -6430,6 +6453,20 @@

The current patch (bind-9.8.0-P1-geoip-1.3.patch) leads into an assertion error 
when starting bind (9.9.0 when built with threading support).

For more details please take a look at:
https://bugs.gentoo.org/show_bug.cgi?id=406397

What steps will reproduce the problem?
1. Download source and patch
2. Patch as per docu "see error of patching below" - autconf-compile with 
--with-geoip 
3. No errors during compilation or run 

What is the expected output? What do you see instead?

Expecting to see GeoIP dbs loaded on start up or run, but nothing happens, all 
works as if no GeoIP was ever loaded, did use simple US test setup and tried to 
test from various locations.

See config 

view "US" {
        match-clients { geoip_cityDB_country_US; };
                 include "/etc/named.rfc1912.zones";

};

What version of the product are you using? On what operating system?
CentOS 64 6.4
Default RPM Installation of everything else.

Please provide any additional information below.

[root@sj bind-9.9.5]# patch -p0 -b < bind-9.9.2-geoip-1.3.patch
patching file version
Hunk #1 FAILED at 7.
1 out of 1 hunk FAILED -- saving rejects to file version.rej
patching file bin/named/geoip.c
patching file bin/named/Makefile.in
Hunk #1 succeeded at 93 (offset 6 lines).
Hunk #2 succeeded at 108 (offset 6 lines).
patching file bin/named/server.c
Hunk #2 succeeded at 4875 with fuzz 2 (offset -425 lines).
Hunk #3 FAILED at 5461.
Hunk #4 succeeded at 6461 (offset 553 lines).
1 out of 4 hunks FAILED -- saving rejects to file bin/named/server.c.rej
patching file configure
Hunk #1 succeeded at 28 (offset -505 lines).
patching file configure.in
Hunk #1 succeeded at 1013 (offset 75 lines).
patching file lib/isccfg/aclconf.c
patching file lib/isc/include/isc/geoip.h
patching file lib/dns/acl.c
Hunk #2 succeeded at 444 (offset 3 lines).
Hunk #3 succeeded at 497 (offset 3 lines).
patching file lib/dns/include/dns/acl.h

What steps will reproduce the problem?
1.Install GeoIP 1.4.8 and BIND 9.9.1-P2 ,bind-9.9.1-P2-geoip-1.3.patch
2.Compile GeoIP with location /usr/local/geoip
3.Compile BIND with Geoip location /usr/local/geoip

I always see this error when perform the "configure" step in BIND compilation 
configure: error: GeoIP library not found

What version of the product are you using? On what operating system?
GeoIP 1.4.8 and BIND 9.9.1-P2 ,bind-9.9.1-P2-geoip-1.3.patch
Sun SPARC Solaris 10 10/09 s10s_u8wos_08a SPARC


Please provide any additional information below.
- Debug geoip installtion
- Debug patch geo 
- Debug BIND installtion with geoip patch
- Compare with the same all things except OS is Centos 5.3
I think the issue related with OS patching compatibility (solaris 10 is not 
supported)

What steps will reproduce the problem?
1. Determine what version is compatible
2. Find the source for said version
3. Spin wheels

What is the expected output? What do you see instead?
Better documentation or pre-patched source.

What version of the product are you using? On what operating system?
None, CentOS 5.10/6.5 x86 / x86_64

Please provide any additional information below.
It would be nice to have better documentation to understand what versions are 
compatible.

E.G as of this writing, the latest BIND for CentOS:

5.10 == 9.7.0-17.P2.el5_9.2
6.5  == 9.8.2rc1-RedHat-9.8.2-0.23

To that, none of the compatible versions are listed as downloads at ISC:
http://www.isc.org/downloads/

So where do you get the compatible BIND source code?

An alternative, would be to supply an already patched tarball that can be 
downloaded and compiled so one doesn't have to hunt to find the proper tarball 
to match the patch compatibility version.

Adopting the project would be more widespread if there were less hurdles at the 
forefront.

Thank you!

Hopefully this is just something obvious that is missing, but I arrived at this 
problem on FreeBSD 8.2 (x64) as well.

Syslog:
May 12 09:22:46 x named[71208]: starting BIND 9.8.0-P1-geoip-1.3 -t /var/named 
-u bind
May 12 09:22:46 x named[71208]: built with '--localstatedir=/var' 
'--disable-linux-caps' '--disable-symtable' '--with-randomdev=/dev/random' 
'--with-geoip=/usr/local' '--disable-openssl-version-check' '--without-openssl' 
'--with-libxml2=/usr/local' '--with-idn=/usr/local' 
'--with-libiconv=/usr/local' '--enable-largefile' 
'STD_CDEFINES=-DDIG_SIGCHASE=1' '--enable-ipv6' '--enable-threads' 
'--sysconfdir=/etc/namedb' '--prefix=/usr' '--mandir=/usr/share/man' 
'--infodir=/usr/share/info/'

general.log in named's logs:
12-May-2011 09:22:47.318 GeoIP Country DB not available
12-May-2011 09:22:47.318 GeoIP City DB Revision 0 or 1 not available
12-May-2011 09:22:47.318 GeoIP Region DB Revision 0 or 1 not available
12-May-2011 09:22:47.318 GeoIP ISP DB not available
12-May-2011 09:22:47.318 GeoIP Organization DB not available
12-May-2011 09:22:47.318 GeoIP AS DB not available
12-May-2011 09:22:47.318 GeoIP NetSpeed DB not available
12-May-2011 09:22:47.318 GeoIP Domain DB not available
12-May-2011 09:22:47.318 GeoIP Country DB IPv6 not available
12-May-2011 09:22:47.322 running

The Maxmind databases are in /usr/local/share/GeoIP on FreeBSD.
Bind was installed with overwrite-base at some point, which I believe is the 
only thing that may affect paths, but symlink'ing /usr/local/share/GeoIP to 
/usr/share/GeoIP did nothing.

I tried to make the most minimal modifications needed, so I downloaded the 
current patch to /usr/ports/dns/bind98/files/

Then modified the Makefile slightly adding:
CONFIGURE_ARGS+=        --with-geoip=/usr/local
EXTRA_PATCHES+=         ${FILESDIR}/bind-9.8.0-P1-geoip-1.3.patch

and then running autoconf in work/bind-9.8.0-P1 after one make install attempt 
(the patch modifies a makefile to abort)

On the second make install, it continues.

However starting named results in the log entries above. So I think either I've 
missed something or some assumption has been made somewhere in the code that 
assumes a path.

I have setup some views (one of them uses geoip_countryDB_country_AU) based on 
the guide at https://code.google.com/p/bind-geoip/wiki/UsageGuide and it works 
for IPv4 queries but for IPv6 queries it just uses the default view.  If I 
check the client IPv6 address with geoiplookup6 it returns the correct country 
and the bind logs show that the IPv6 Country DB has been loaded.

This likely me just be me doing it wrong, but when I start bind it doesn't seem 
to find any of the databases. I have placed GeoLiteCity.dat in:

/opt/Geo-IP-RPM/usr/local/share/GeoIP/GeoLiteCity.dat

(I also tried replacing the GeoIP.data that was there with this file)

Dec  2 08:18:26 localhost named[23324]: built with 
'--prefix=/opt/bind-9.7.2-P2-GeoIP-RPM/usr/local' '--with-libtool' 
'--enable-threads' '--enable-ipv6' '--with-pic' '--with-openssl=/usr/' 
'--with-geoip=/opt/Geo-IP-RPM/usr/local' '--with-geoip-debug'
...

Dec  2 08:18:26 localhost named[23324]: GeoIP Country DB not available
Dec  2 08:18:26 localhost named[23324]: GeoIP City DB Revision 0 or 1 not 
available
Dec  2 08:18:26 localhost named[23324]: GeoIP Region DB Revision 0 or 1 not 
available
Dec  2 08:18:26 localhost named[23324]: GeoIP ISP DB not available
Dec  2 08:18:26 localhost named[23324]: GeoIP Organization DB not available
Dec  2 08:18:26 localhost named[23324]: GeoIP AS DB not available
Dec  2 08:18:26 localhost named[23324]: GeoIP NetSpeed DB not available
Dec  2 08:18:26 localhost named[23324]: GeoIP Domain DB not available
Dec  2 08:18:26 localhost named[23324]: GeoIP Country DB IPv6 not available
Dec  2 08:18:26 localhost named[23324]: running