tais993 / prisonutilmod Goto Github PK

Display how much the inventory is worth at the top left

Currently, most commands send nothing back.

After the command rework #16, this should be immediately taken care of as-well.

The current state is fine for testing, but cannot be released.

• !reset-mine
• !reload
• !reload-map

Display the to-do list:

Display the icon of the item, and include the display name.
This follows the total required / total left or something alike.

Easy access way to pick items

Based of the items given, calculate how much the inventory is worth

• Refactor recipe checking to a different class
• Add support for multiple items
• Add support for 1 item being selected multiple times
• Add support for only listing the vanilla Minecraft items

Rework the commands, so they're all in a single place, which majorly can improve maintenance.

• Single place for commands
• Help commands

There are 2 ways to receive an item, 1 is by purchasing, the other by crafting the item.
Purchasing an item can only happen a certain number of times, this is also the case for purchasing the item you need to craft.

It also is a factor that crafting takes time, directly buying a part can be a lot faster over crafting it.

This means that a pure craft should contain a multitude of items, which are:

• item identification

  • item tag
  • nbt display name

• purchase price

• sell price

• recipe

To actually identify the most useful way of money, some things should be added

• purchase limit
• should buy instead of craft
• whenever to smelt before selling

Currently the map gets loaded the first time the method or the !reset-map command gets ran, this is inaccurate.

Preferably, it automatically reloads when new recipes are given to the client.
Or, when the player leaves/joins a world.

The mine gets reset EVERY 5 minutes, even when no blocks have been mined or no player is around.
So create a timer which starts when the blocks respawn, and resets every 5 minutes.
If possible, store the timer & server state somewhere. So the user can log back in, or possibly even restart and the timer keeps working.
Unsure whenever it's possible to know or the server has restarted in the main time.

• Detect mine reset
• Timer which resets every 5 minutes
• Figure a way out to know or a server has been restarted since the last time online
• Make timer persistent throughout client restarts

Crossed out items will be moved to separate issues

Add a readme which explains how to install, use and modify the mod.

• How to install the mod
• How to use the mod (in game)
• How to edit options
• Index

Create a lock so the timer variable cannot be accessed at the same time

Regardless of the tag the player gives, the item is always null

Detecting a mine reset should be done by listening to block changes

The issue

Due to the way Forge was build, it isn't possible to listen to block changes made by people.
Listening to the event in the network was mentioned as impossible as-well.

This means there's as of right now no viable way of detecting mine resets.

The solution

The alternative is a plugin, which sends all clients / all clients with the mod an custom event, so the clients know the mine is reset.
This requires the server owner to add a plugin though, I'll try to talk about the owner with it. But doubtful in success, when the prison plugin gets replaced by the rework changes are much higher it's possible. As of right now, nothing will be done.

Make the timer persistent, this way quick restarts won't break the gameplay.

But, when the game is restarted add a warning until the timer has been verified.
The timer can be verified by #11

Dependencies

#11

Create BasicItem class

This class should maintain an item's info:

• item purchase price
• item sell price
• item key
• item NBT display.name if exists
• recipe for craft

By reserving X to be minecraft:air, many recipes will be decent amount shorter.

So this helps with maintainability, and in return there's no true downside.