GithubHelp home page GithubHelp logo

Comments (1)

dedoardo avatar dedoardo commented on July 19, 2024 1

From a read through the code I noticed the following issues:

  • We currently rely on the cycles tokens to distinguish whether a curve is a cylinder or flat. The usd specification states that it is something that should be deduced from the presence of widths or not. We should have both options.
  • The wrap mode of curves seems to be ignored (same goes for basis/type).
  • I read that for cubic curves to linearly interpolate a primvar you use 'Varying' but in the code I see 'Vertex'
  • I miss the context for the older curves (closing cylinders as tubes?). I wonder if we still need it...

In general I think the code could use being revisited, possibly with a simple test scene containing all possible combinations of inputs.

from hdblackbird.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.