tangojs / issues Goto Github PK

the page slows down after a few reloads

Issues to address:

• grid layout usage
• model to widget mapping

All other components are impacted and should be aligned

        const lineEdit = document.createElement('tangojs-line-edit')

        lineEdit.setAttribute('model', 'tangojs/test/dev1/scalar')
        lineEdit.pollPeriod = 1000

Above does not display name, unit and status led

Prototype chain is lost when derived event is received in Chrome (__proto__ points directly to Event).

Related to this:
https://bugs.chromium.org/p/chromium/issues/detail?id=495437

  /**
   * @return {Promise<AttributeInfo>|Promise<AttributeInfo[]>}
   * @param {string} devname
   * @param {undefined|string|string[]} attnames
   */
  get_device_attribute_info(devname, attnames) {

Such overloads shall be handled at tangojs-core level, and connector shall simply take string[] and return a Promise<AttributeInfo[]>.

Also consider dropping CoffeScript

ES2017+ brings the Promises with async/await which are more readable syntax.

What may prevent to use EcmaScript 2017?

• use element.attachShadow instead of deprecated createShadowRot (all components affected)
• use slot instead of content insertion point (button affected)

This issue is blocked until these features are implemented in both FF and Chrome.

Github resolves commit ref @xxxxxxx against apidocs repo. Change it to sth like tangojs/tangojs-core@xxxxxxx. Repo name may be extracted from package.json (?)

npm install (in package directory, no arguments):

Install the dependencies in the local node_modules folder.

In global mode (ie, with -g or --global appended to the command), it installs the current package context (ie, the current working directory) as a global > package.

By default, npm install will install all modules listed as dependencies in package.json.

With the --production flag (or when the NODE_ENV environment variable is set to production), npm will not install modules listed in devDependencies.

The led is always blue

The code assumes that the connector returns enum instances, but according to the IDL ordinals should be returned.

Command button requires restructuring: it should:

• use "form-layout" like line-edit or label
• optionally show input (text-field) and last output

Remove 'multipleModels' capability

Each attribute also should have a description

When user changes value in line-edit using spinner button, the browser freezes and CPU usage goes 100%.

This was observed only on Firefox, starting from v. 46.

I was unable to reproduce the issue on Chrome.

Like in mliszcz/tangojs-panel@bb7aa1b

Classes should be separated into two packages:

• tangojs.core.tango - generated stuff,
• tangojs.core.api - exact copy of Tango Java API,
• [optional] tangojs.core.api2 extensions for API classes (e.g. DeviceProxyEx or api2.DeviceProxy) which are like original Tango API but also sane, consistent and intuitive.