tangrams / cinnabar-style Goto Github PK

View Code? Open in Web Editor NEW

10.0 10.0 11.0 3.09 MB

Colorful cartography for that classic look

Home Page: http://tangrams.github.io/cinnabar-style/

License: MIT License

HTML 63.39% JavaScript 36.22% Makefile 0.39%

cinnabar-style's People

Contributors

Stargazers

Watchers

Forkers

htaflin fly2279 pnorman climax777 teester dbdean redfish64 anagraph thejeshgn srikanthlogic siloam

cinnabar-style's Issues

show major barriers like barrier=fence or barrier=wall

Is there a chance that PR implementing feature like this would be accepted?

Add theme variants for more, no labels

Versus keeping the parallel repos up-to-date

consider deleting dead code

At the end of style

#    transit-bus-roads:
#        data: { source: mapzen, layer: roads }
#        filter:
#            all:
#                - is_bus_route: true
#                - function() { return global.sdk_transit_overlay; }
#        draw:
#            lines:
#                interactive: false
#                color: [[13,[0,0,1,0.5]],[15,blue]]
#                width: [[11,0.5px],[12,0.8px],[16,1.25px],[18,1m]]
#                # let roads sort themselves past zoom 14
#                order: 488
#                # but give them all the same outline
#                outline:
#                    order: 487

is present. I think that this code should be deleted (history is handled by git history, ongoing implementation probably should be handled in an issue/pull request).

broken oneway arrows

I attempted to reuse code from 26f200e to add oneway arrows and discovered that arrow sprite appears to be broken

Arrow sprite seems to be a rectangle - effect is visible in
https://mapzen.com/tangram/play/?#18.50000/50.06934/19.94990

(note small squares scattered across roads)

I tested arrow sprite definition to display at specified POI, small square also appeared there.

In addition I see no oneway sprite in 26f200e#diff-e82ec2de2911d77ed0457513f4f705a7

Collision is disabled for some city labels

https://github.com/tangrams/cinnabar-style/blob/gh-pages/cinnabar-style.yaml#L4205

This has been observed to produce some overlapping labels in tangram-es:

Investigate inconsistency between ES and JS renderers

As off commit, 38719cd, @nvkelso and I are seeing some inconsistent renders between JS and ES.

Refer screen shots for details:

However one small change of disabling building extrusion polygons, fixes the renders on ES.
https://github.com/tangrams/cinnabar-style/blob/gh-pages/cinnabar-style.yaml#L2907

This issue is not reproducible on other house style.

There might be some issue with the style sheet which is causing this inconsistent state between the renderers, or there could be some issue with ES code, still needs some investigation to iron out the issue.

weird border rendering for some spots

Add arrows for one-way streets

Remove Zinc color theme

In #42 we fixed a bunch of bugs and added Zinc as a color theme.

Upon reflection, we're porting Zinc to Refill instead. Rather than supporting both options, let's remove Zinc as a color theme on Cinnabar (but keep the rest of the changes in #42).

Remove the color/zinc theme file
Move cinnabar colors from theme file into main YAML (and remove empty themes dir)
- This will cut down on number of network requests, amount of indirection
Remove dat.GUI options for color
Docs
& etc

Display bus stops

Could I submit a PR to display bus stops on the map? They are defined around https://github.com/tangrams/cinnabar-style/blob/gh-pages/cinnabar-style.yaml#L5068, but it doesn't seem to work properly.

Move to generic API key URLs with url_params

See proposed solution in tangrams/cartography-docs#2 (comment).

This is needed for iOS SDK launch.

Add left, right boundary line labels

Not rendering road over building correctly

See: streetcomplete/StreetComplete#292

How to use cinnabar style with openLayers 3?

I see documentation for Leaflet. Can I use cinnabar style with openLayers too?
Is there any basic example? Thanks in advance!

Please, take a look to a basic example (I see only the vectors, without the tangrams scene).

Buildings look bad in tilted 3d view

Using this style in Tangram ES with a tilted view the buildings get all smooched together. They need something to differentiate them, maybe add a vertical stroke? And/or change building exaggeration (eg: Zinc doesn't exaggerate at all so even though it would have the same problem, it doesn't because of the config)?

Default labels should enable all road labels early

To match the JS rig, and related to tangrams/tangram#484 (comment). The older logic is from Tangram era 0.7 but articulated labels changes more recently and the about to land curved labels make these labels look good earlier now.

Here's what the JS has, the YAML for the default labels scene file should mark them true (currently false).

text_visible_highway_e = _default;
text_visible_minor_road_e = _default;
text_visible_highway_e = _default;
text_visible_trunk_primary_e2 = _default;
text_visible_trunk_primary_e = _default;
text_visible_secondary_e = _default;
text_visible_tertiary_e = _default;
text_visible_minor_road_e = _default;
text_visible_exits_e = _default;

Address Tangram ES warnings

Some of these are just chatter, some should be fixed:

TANGRAM map.cpp:231: Loading scene file (async): /Users/nvkelso/git-repos/cinnabar-style/cinnabar-style.yaml
WARNING sceneLoader.cpp:172: Global reference is undefined: layers.landuse.minor-landuse.draw.outline.color <= gray1_e
NOTIFY sceneLoader.cpp:770: Adding local font /Users/nvkelso/git-repos/cinnabar-style/fonts/OpenSans-Light.woff (open sans-300regular.ttf)
NOTIFY sceneLoader.cpp:770: Adding local font /Users/nvkelso/git-repos/cinnabar-style/fonts/OpenSans-Regular.woff (open sans-400regular.ttf)
NOTIFY sceneLoader.cpp:770: Adding local font /Users/nvkelso/git-repos/cinnabar-style/fonts/OpenSans-Italic.woff (open sans-400italic.ttf)
NOTIFY sceneLoader.cpp:770: Adding local font /Users/nvkelso/git-repos/cinnabar-style/fonts/OpenSans-Semibold.woff (open sans-600regular.ttf)
NOTIFY sceneLoader.cpp:770: Adding local font /Users/nvkelso/git-repos/cinnabar-style/fonts/OpenSans-SemiboldItalic.woff (open sans-600italic.ttf)
NOTIFY sceneLoader.cpp:770: Adding local font /Users/nvkelso/git-repos/cinnabar-style/fonts/OpenSans-Bold.woff (open sans-700regular.ttf)
NOTIFY sceneLoader.cpp:770: Adding local font /Users/nvkelso/git-repos/cinnabar-style/fonts/Montserrat-Regular.woff (montserrat-400regular.ttf)
NOTIFY sceneLoader.cpp:770: Adding local font /Users/nvkelso/git-repos/cinnabar-style/fonts/Montserrat-Medium.woff (montserrat-500regular.ttf)
NOTIFY sceneLoader.cpp:770: Adding local font /Users/nvkelso/git-repos/cinnabar-style/fonts/Montserrat-Bold.woff (montserrat-700regular.ttf)
WARNING styleParam.cpp:159: Unknown StyleParam text:move_into_tile:false
WARNING sceneLoader.cpp:1777: Can't find data source mz_route_line for layer mz_route_line
WARNING sceneLoader.cpp:1777: Can't find data source mz_dash_line for layer mz_route_line_dash
WARNING sceneLoader.cpp:1777: Can't find data source mz_route_line_transit for layer mz_route_line_transit
WARNING sceneLoader.cpp:1777: Can't find data source mz_current_location for layer mz_current_location_gem
WARNING sceneLoader.cpp:1777: Can't find data source mz_route_location for layer mz_route_location
WARNING sceneLoader.cpp:1777: Can't find data source mz_route_start for layer mz_route_start
WARNING sceneLoader.cpp:1777: Can't find data source mz_route_stop for layer mz_route_stop
WARNING sceneLoader.cpp:1777: Can't find data source mz_route_transit_stop for layer mz_route_transit_stop
WARNING sceneLoader.cpp:1777: Can't find data source mz_search_result for layer mz_search_result
WARNING sceneLoader.cpp:1777: Can't find data source mz_dropped_pin for layer mz_dropped_pin
WARNING sceneLoader.cpp:1777: Can't find data source mz_default_point for layer mz_default_point
WARNING sceneLoader.cpp:1777: Can't find data source mz_default_shield for layer mz_default_shield
WARNING sceneLoader.cpp:1777: Can't find data source mz_default_line for layer mz_default_line
WARNING sceneLoader.cpp:1777: Can't find data source mz_default_polygon for layer mz_default_polygon
WARNING styleParam.cpp:159: Unknown StyleParam cull_from_tile:true
WARNING styleParam.cpp:159: Unknown StyleParam cull_from_tile:true
WARNING styleParam.cpp:159: Unknown StyleParam cull_from_tile:true
WARNING styleParam.cpp:159: Unknown StyleParam move_into_tile:true
WARNING styleParam.cpp:189: Invalid offset parameter '0,5px,'.
WARNING styleParam.cpp:189: Invalid offset parameter '0px'.
WARNING styleParam.cpp:189: Invalid offset parameter '0,5px,'.
WARNING styleParam.cpp:189: Invalid offset parameter '0px'.
WARNING stops.cpp:71: Error while parsing font size stops: 12.000000 21x
WARNING styleParam.cpp:159: Unknown StyleParam move_into_tile:true
NOTIFY tileManager.cpp:53: Remove source osm
NOTIFY tileManager.cpp:72: add source mapzen
TANGRAM tileWorker.cpp:51: Passed new TileBuilder to TileWorker
LOADED Font: Open Sans Italic size: 28
LOADED Font: Open Sans Regular size: 40
LOADED Font: Open Sans Regular size: 28
WARNING platform.cpp:29: Failed to read file at path: /Users/nvkelso/git-repos/cinnabar-style/fonts/varela-200regular.ttf
LOADED Font: System Font Thin size: 28
TANGRAM tileWorker.cpp:51: Passed new TileBuilder to TileWorker
LOADED Font: Open Sans Light size: 28
LOADED Font: Montserrat Regular size: 28
LOADED Font: Open Sans Light size: 40

Use Bubble Wrap's new POI layer config

Add transit overlay SDK support

Like we have for Bubble Wrap

poor display of bridge over pond in the park

http://www.openstreetmap.org/?mlat=50.06578&mlon=19.94020#map=19/50.06578/19.94020
https://mapzen.com/tangram/play/?#20.00000/50.06576/19.94025

Note that bridge starting on the edge of water is correct mapping for that case (I guess that problem is caused by displaying pond bigger than mapped, or making edge of water appear on top of footway).

BLOCKED: UX Language Short name Fallback

At zoom levels 7 and above, the map fallbacks to English which is fallback language of Tamil.

https://srikanthlogic.github.io/osm-ta/TamilMap.html

But it would be nice to have a switch to determine how the fallback should happen when short names are missing. (ie, within the language [pure language map] or fallback to short names in fallback language.

ux_language_text_source_short
ux_language_text_source_short_proxy_name

are the functions where this is implemented.

Add localized language SDK support

Like we have for Bubble Wrap

use cap: round for paths and roads

I am not planning making PR due to very high complexity of style, but it seems that cap:round would be useful for paths

for example https://github.com/matkoniecz/cinnabar-style/commit/33aec7e90652b09c43c228e107579a86e9fb06da makes following difference at https://mapzen.com/tangram/play/?#20.00000/50.08020/19.88489

from

It affects not only baths - see bottom right of https://user-images.githubusercontent.com/13661397/27248826-e48fa0ae-5300-11e7-9349-2d1e065eb34d.png (spotted in streetcomplete/StreetComplete#340)

highway=pedestrian + area=yes (squares, plazas) are missing

Pedestrian areas were added in some tangram styles after tilezen/vector-datasource#1312

example: https://mapzen.com/tangram/play/?#20.00000/50.05667/19.93490

Update documentation to reflect how to get different styles/themes

Currently the README points to other repositories to get the more labels and no labels styles, but those repositories say they aren't maintained, and point me back here.

I gather from poking around in the code that the different styles can be chosen by changing the themes/label-XX.yaml file that is imported at the top of cinnabar-style.yaml, where 0 is less details, and 11 is the most?

Can the documentation in the README (and elsewhere as appropriate, I guess) be updated to reflect how the different label styles are supposed to be chosen. If my guess above is correct, it would also be nice if the label-XX.yaml files were named to better reflect the changes in each one.

Thanks!

first line is completely useless an second has smaller requirement

not sure what is the intended meaning - delete first/second line? Decrement all z-levels from lowest to first duplicated? Increment all from first duplicated to highest?

BLOCKED: show access=private/no

Currently restricted access is not displayed on highway=*

For typical purposes it is preferable to indicate that road has no access.

tangrams / cinnabar-style Goto Github PK

cinnabar-style's People

Contributors

Stargazers

Watchers

Forkers

cinnabar-style's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs