tanin47 / git-notes Goto Github PK

Hi, I just attempted to install git-notes on a new machine, but I ran into a minor issue with the install instructions, which meant that it didn't produce the git-notes binary.

And thanks for the otherwise flawless tool ;)

Steps

1. Run go build *.go inside the root of the repo

Expected

The git-notes binary is built.

Actual

The binary isn't built. (No output is given by the command).

Workaround

When I ran go build (without *.go) it suggested that I initialize the module with go mod init.
After initializing the module, the binary was produced by running go build.

So, at least for macOS, the build instructions should be go mod init; go build 😊

Setup

• OS: macOS 11.6.5
• Go: 1.18.4

Could you add explicit license to repository (for example in LICENSE file or in the README?)

Without explicit license this project is „All right Reserved”, even if
that's your intent it would be better to state that explicitly.

Hi Tanin,
First off, thank you for this great little tool!
I've been using it without any problems on my two machines for more than a year now :-)

The issue:
I noticed today that my git-notes wasn't working on MacBook despite it still running.
The logs (from Console.app) show that it fails to get the status, i.e. running git status --porcelain:

Git notes is monitoring /Users/kasper/org
Failed to get state. Error: unable to get status. Error: exit status 1
Failed to get state. Error: unable to get status. Error: exit status 1
...

When I run the executable directly, it works as expected.
So I figured the service was acting up and I reloaded it but to no avail.
Then I unloaded the service and reinstalled the whole thing following your instructions. But the same problem still occurs.

I updated my MacBook to Monterey yesterday, but I did the same with my Mac Mini (on which git-notes still works).
I don't think I've changed anything else noteworthy recently.

Do you have an idea of what the problem could be or what I could try to debug this?

I'm curious what's causing this error. It's not a blocking issue--these changes and a couple others were successfully committed to my local repo. It reproduces consistently, with every detected change.

• It's interesting to me that the starting state is error.
• Changes were indeed committed, but they were not pushed.
• This is a work machine, so I obscured the hostname (LAPTOP-HOSTNAME).

❯ ./git-notes git-notes.json
2020/06/11 15:07:02 Git Notes is starting...
&{[/Users/tcondit/Bender/3_Resources/vimwiki/]}
2020/06/11 15:07:02 Computing the state of /Users/tcondit/Bender/3_Resources/vimwiki/
2020/06/11 15:07:03 Starting state: error
2020/06/11 15:07:03 Syncing failed. Err: performing GetState() failed. Err: unable to parse status: ## LAPTOP-HOSTNAME...origin/LAPTOP-HOSTNAME
2020/06/11 15:07:03 Git notes is monitoring /Users/tcondit/Bender/3_Resources/vimwiki/
2020/06/11 15:08:03 Changes have been detected.
2020/06/11 15:08:05 Computing the state of /Users/tcondit/Bender/3_Resources/vimwiki/
2020/06/11 15:08:05 Starting state: dirty
2020/06/11 15:08:05 Computing the state of /Users/tcondit/Bender/3_Resources/vimwiki/
[LAPTOP-HOSTNAME df32c77] Commited at 2020-06-11 15:08:05.408897 -0700 PDT m=+63.172554816
 2 files changed, 2 insertions(+)
 create mode 100644 testing-git-notes.md
2020/06/11 15:08:05 Computing the state of /Users/tcondit/Bender/3_Resources/vimwiki/
2020/06/11 15:08:06 Syncing failed. Err: performing GetState() failed. Err: unable to parse status: ## LAPTOP-HOSTNAME...origin/LAPTOP-HOSTNAME [ahead 1]
2020/06/11 15:11:20 Changes have been detected.
2020/06/11 15:11:22 Computing the state of /Users/tcondit/Bender/3_Resources/vimwiki/
2020/06/11 15:11:22 Starting state: dirty
2020/06/11 15:11:22 Computing the state of /Users/tcondit/Bender/3_Resources/vimwiki/
[LAPTOP-HOSTNAME 503a2fb] Commited at 2020-06-11 15:11:22.751097 -0700 PDT m=+260.511405293
 1 file changed, 4 insertions(+)