tapika / swupd Goto Github PK

While running command:

choco install dotnetcore-runtime

Following choco packages fails to install:

...
KB2919442 v1.0.20160915 [Approved]
kb2919442 package files install completed. Performing other installation steps.
Progress: 100% - Getting formatting and output information from remote session ... 115 objects received                                              ERROR: The term 'Get-WmiObject' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
The install of kb2919442 was NOT successful.
Error while running 'D:\Projects\swupd_develop4\bin\netcoreapp3.1-RelWithDebInfo\lib\KB2919442\tools\ChocolateyInstall.ps1'.
 See log for details.

KB2919355 v1.0.20160915 [Approved]
kb2919355 package files install completed. Performing other installation steps.
Progress: 100% - Getting formatting and output information from remote session ... 115 objects received                                              ERROR: The term 'Get-WmiObject' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
The install of kb2919355 was NOT successful.
Error while running 'D:\Projects\swupd_develop4\bin\netcoreapp3.1-RelWithDebInfo\lib\KB2919355\tools\ChocolateyInstall.ps1'.
 See log for details.
...

So far Chocolatey GUI was installed either via choco itself, see for example in here:

https://github.com/chocolatey/ChocolateyGUI#installation

Or using Wix installer building

https://github.com/chocolatey/ChocolateyGUI#building

Where releases in a turn contain .msi package:

https://github.com/chocolatey/ChocolateyGUI/releases

To be able to install .net framework, which application itself requires.

At the moment choco (swupd fork) can be run as standalone application, without requiring to install .net framework.

One approach is just show where to install and perform "choco install" into end-user selected folder.

This maybe requires some deeper knowledge on what is placed in registry itself (For example wix installer behavior)

Second approach is just to use 'choco install chocolateyGUI' to make initial deployment of choco + gui to PC.

Something to consider:

• If choco is used for updating application, and user decides to cancel software update in a middle of update - to what state installer should return to ?

  • Wipe out old and new application - will installer (~choco) itself be preserved somewhere, where ?
  • preserve old version and waste some time for software update cancelling

• At the moment Chocolatey GUI requires choco installation. Could there be just one installation ?

https://github.com/tapika/swupd/blob/master/src/chocolatey.resources/tools/shimgen.license.txt

Even this shimgen is by default now in disabled state, but it's still included in ReadyToRun build, and potentially in coming new installation package.

Need to remove shimgen from further distribution.

Maybe could be build time controlled.

Windows build seems to work more or less ok - Linux port had several issues thus.

One of the problem is ProtectedData.Protect ProtectedData.Unprotect are not available on .NET Core.

See dotnet/runtime#22886

Leaving these as they currently are is causing notifications to be sent to our email address when you run builds.

Specifically, I am requesting that this lines be removed:

choco pack c:\test\test.nuspec compresses c:\test folder.

It should be possible to use different folder than .nuspec.

For example:

choco pack c:\test\test.nuspec --in c:\inputfolder

@tapika The NOTICE file (which you can find here: https://github.com/chocolatey/choco/blob/develop/NOTICE) has been removed from this repository.

Can I please ask that this is restored.

See build for example:

https://github.com/tapika/swupd/actions/runs/3371837993/jobs/5594562127

========================================
upload_coverage_results
========================================
runId: 3371837993, branchRef: develop, commitId: ec0f792662bdb10498bf1090b30357baf3a1d4c2
...
'
Uploading coverage report Cobertura.xml to coveralls.io...
Executing: "D:/a/swupd/swupd/tools/coveralls.io.1.4.2/tools/coveralls.net.exe" --cobertura "D:/a/swupd/swupd/build_output/build_artifacts/codecoverage/Html/Cobertura.xml"
Error BadRequest sending to coveralls.io: Bad Request
 - Error code 422 indicate a problem with your token. Use the --debug option for more details.

Raised issue in right repo: coveralls-net/coveralls.net#49

Not sure if it will be fixed, ~4-5 years since last change.

There are several issues with clean up in choco.

1. %TEMP%\NuGetScratch
   When installing / upgrading & uninstalling - zips being processed are extracted into temporary folder and remains in there.
   choco itself has a guard mechanics related to this, for example there exists function remove_nuget_cache - but this would not work if choco is used as nuget package. And even from cli it does not work for some reason, haven't analyzed in depth.

Same or similar issue is also reported in Chocolatey #837

Originally nuget has also API for clean up NuGetScratch, like OptimizedZipPackage.PurgeCache(), but it's not used.
Same issue persists also for integration tests, chocolatey's CacheLocation does not seems to override %TEMP%\NuGetScratch folder.