taraman17 / nodejs-cs2-api Goto Github PK

This seems to be in connection with an issue in the rcon library I use.
Bug there is:
EnriqCG/rcon-srcds#9

For now, try startup some times or stop and restart server.

To make the API really RESTful, the authentication should work stateless.
With the current steam solution, a user interaction is required, so I will add digest authentication, to allow for automated calls sending the credentials.

Code scanning brought up 4 issues that should be fixed

Now that we have a user authentication, I will add logging to a logfile, so that one can see who did what on the server.

If there is a large update or with validation turned on, the update might take so long that the request by the client times out and the answer is not received.

If the Hosted map collection changes while the server is running, maps can be added or removed from the server.
Since maps are automatically only loaded on startup to minimise the rcon traffic, I will add a function to update the list manually

To anhance security, communication via https should be possible for the GET-requests as well as websocket.

The Repo should have a dependencies file.

For security reasons, the requests should only be available to authenticated clients.

Current Idea is to use steam authentication API, since the usual user will have a steam account.

To keep maplists more manageable, a filter will be introduced so one can e.g. Filter out ar_* maps in the list.

For some reason, the code to react on the mapChangeEmitter got deleted:

    // follow mapchange
    } else if (args.action == "mapstart") {
        mapChangeEmitter.once('completed', () => {
            res.writeHeader(200, {"Content-Type": "application/json"});
            res.write(`{ "completed": true }`);
            res.end();
        });
    }