GithubHelp home page GithubHelp logo

balanced-notify's People

Contributors

tarunc avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar

Forkers

mahmoudimus

balanced-notify's Issues

Changes to finish up MVP

Tests

  • change tests to check http response codes. e.g. creates should give 201, deletes 204, gets 200
  • add negative tests, e.g. unauthorized should return 403 or 401.
  • negative tests e.g. delete a notification that doesn't exist, delete a notification that doesn't belong to that user, create a notification when not an admin, double delete a notification.
  • remove print/debug statements

App

  • load different configs based on environment variable. e.g app / tests will be instantiated with BALANCED_ENV=test ./run.py and doing so should load all settings from app/settings/test.py. there should be a default settings file and then we override setting based on the environment. here's some code to help achieve this

    config = flask.config.Config(None, flask.Flask.default_config)
    config.from_object('app.settings.default')
    if os.getenv('BALANCED_ENV'):
        config.from_object('app.settings.' + os.getenv('BALANCED_ENV'))
  • finish pep8'ing the code base. no lines longer than 80 chars.

  • noCamelCased method names, use_underscores_instead

  • change createModel to just create

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.