tastejs / next-movies Goto Github PK

A few things to note:

• I'm not sure we need Redux here, the other examples don't have it
• Let's try to be 1:1 on CSS solutions - others are using Tailwind CSS, so use that
• To be a more accurate comparison with other frameworks server-first, I recommend exploring the app directory
• I would avoid ejecting the webpack plugin
• Can probably remove a lot of the custom react-* packages added, which are increasing client JS, in comparison to other framework examples which aren't doing this

@addyosmani
I think we should write down a good README.md. :)

I noticed a few folks are already sharing this app :) This implementation is from around August and we have quite a few months of refinements made to it that we will still be landing to the repo from the mono-repo we've been working in.

@anton-karlovskiy could you add the PR for those changes?

@addyosmani
FYI: we should update social media tags properly. content attributes are empty strings now.

The link http://next-movies-zeta.vercel.app/ in Readme does not work

@addyosmani
I think the repository is not configured with CI/CD integration.
I think we can use Vercel as it's a Next.js project, although we used Netlify during the development.

@anton-karlovskiy Would you be interested in making this change? KEY and token are currently committed to the repo. I think this is probably the last change we might want to make before tagging a proper release.