tbela99 / inplaceeditor Goto Github PK

I noticed the code messes up tables, which is where I am working.

This code change just replaces the 'span' you were creating as the container, and uses the node type that the end-user supplies (el.nodeType)

    build: function (el) {
        var options = this.options,
            oldValue = el.get(options.property);
            /* Mess up tables:  container = new Element('span').injectAfter(el), */

        /* Duplicate the typof of node - important in tables */
        var container = new Element( el.nodeName ).inject(el, 'after');

        var textarea = new Element(
            options.element, options.properties).set('value', oldValue
        ).inject(container);

Hi again

The plugin is working really well for me, but please would you consider these issue?

• Currently we can set colours: would it be possible to instead (or as well, I suppose, for backwards computability) by possible to supply a class name for the element hovering, so that the plugin would add and remove the class name?
• Would it be possible to have the Save and Cancel options be styled buttons, to avoid the 'javascript:' link?
• Could the whole editor be either wrapped in a namable entity, or could the save/cancel links be given names or classes, so that can be easily styled?

Thanks for reading and for the module!

Lee

Thanks for a useful module!

I think your Mootoosl Forge page states 1.3.1 compatability, but the main JS file has the following on line 69:

container = new Element('span').injectAfter(el),

This fails on my 1.3, unless I change it to:

container = new Element('span').inject(el, 'after'),

HTH
Lee