GithubHelp home page GithubHelp logo

tbenson89 / gpstechnicalinterview Goto Github PK

View Code? Open in Web Editor NEW

This project forked from nkiayal/gpstechnicalinterview

1.0 0.0 0.0 926 KB

This project is a loan application tool built with .NET, Angular and Material.

JavaScript 2.75% C# 20.82% TypeScript 50.27% CSS 0.61% HTML 18.98% SCSS 6.57%

gpstechnicalinterview's Introduction

GPS.ApplicationManager.Web Tyler's Loan Application

This project is a loan application tool built with .NET, Angular and Material. The user interface features a custom design that is visually appealing and user-friendly. Users can create, edit, and delete applications.

Sample Data

Copy sample data from /loanApplication_Sample.json to /loanApplication.json (if you want to start with sample data or you can start by the default seed data)

Areas for Improvement

While working on the Loan Application project, there are a few areas where I believe I could have made further improvements had I had more time:

  1. Utilizing async/await and promises: I would revise the loadApplications() function to leverage async/await and utilize promises/catch() for better error handling and to showcase my proficiency in creating asynchronous applications.
    • I would also utilize the async | pipe and $streams - to avoid memory leaks and eliminate the need for manual subscription management in ngOnDestroy. This eliminates the need to manually unsubscribe in the ngOnDestroy lifecycle hook, resulting in cleaner and more efficient code.
  2. Enhancing error message logic: I would improve the logic for displaying error messages by making it more dynamic and cleaner. Instead of nesting multiple else if statements, I would store error messages in an array and loop/map through them to extract and display only the relevant validation errors for each form control.
  3. Strengthening validators: I would improve the validators by addressing the conflicting currency and numeric validation issue and enhancing server-side validation. This would ensure more accurate data validation and enhance the application's reliability.
  4. Implementing search functionality: I had the ambition to go above and beyond the requirements and implement search functionality. Unfortunately, due to time constraints, I was unable to fully complete this feature. Given more time, I would have implemented a search functionality that allows users to easily search and filter loan applications.

While I acknowledge these areas for improvement, I believe that the Loan Application showcases my abilities and demonstrates my dedication to delivering high-quality code. While being adaptable to different coding standards and practices.

Feedback and Support

If you encounter any issues or have any suggestions for improvement, please feel free to let me know how I can improve. I value your feedback and will actively work towards addressing any concerns you may have.

gpstechnicalinterview's People

Contributors

tbenson89 avatar nkiayal avatar

Stargazers

 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.