tc-mods / trombloader Goto Github PK

Should work the same as the other options, letting you pick enabled, disabled or whatever the player chooses.

Add support for "improv zones", zones in a track that advise the player to improvise a solo

The version of TrombLoader shipped with the trombbackground template is a stripped down version with only the Data classes (and Helpers, if including more up to date builds distributed on the Discord). It also removes all dependencies outside of LeanTween, making distribution far more convenient.

Ideally, this could be facilitated via a build flag, but maintaining a separate fork could also work fine. Alternatively, the relevant scripts could be included in the Unity project directly instead of compiling a DLL.

1.098 added an icon on the Track Select screen for when a song may result in a mute or other potential issues on Twitch.

It would be nice if we could enable this icon for certain copyrighted custom songs that could cause issues on Twitch.

Add support for specifying custom data in chart files that other mods can read.

The Mac shader loader currently only applies loaded shaders to Renderer components:

However, other components such as TextMeshProGUI and Graphic are not being queried here.

Game Version: TC 1.17B
TrombLoader Version: 2.2.1

Description

TrombLoader added a new feature that prevents charts from loading if they are missing a field or have invalid json format. This is a great feature but it only takes few invalid charts (8 in my case) to make the loading time nearly twice as long.

Reproducible?

Easily. Simply create a faulty chart and copy it a few times then compare loading time.

Issue

For me its not too big of a deal since I can delete the chart that are displayed in the console, but for a regular user they may never notice that some of their charts aren't loading correctly. Its fair to assume most users won't have the bepinex console enabled or won't look at their logs so finding an alternative is probably required for invalid charts.

Example of warning message from invalid chart:

Currently the CustomBackground pause callback pauses Animator, Animation and VideoPlayer components.

However, charts have started to make use of a few other components:

• Unity Timeline's PlayableDirector
• Cinemachine's CinemachineDollyCart
• probably some others. investigate!

In the base game backgrounds, charts with solo segments usually darken the background to compensate for the increased brightness of solo sections. custom PNG backgrounds have no way of doing this, however, so they can sometimes appear a bit too bright for some users:

I think we could provide a TrombLoader option that will dim PNG backgrounds during solo sections. Video and Unity backgrounds have more control over how their background is presented, so I don't think this feature is needed there.