GithubHelp home page GithubHelp logo

tcmug / fpiapi Goto Github PK

View Code? Open in Web Editor NEW
14.0 14.0 7.0 349 KB

PHP Api for making Finnish web payments via a handful of banks and Luottokunta.

License: GNU General Public License v2.0

PHP 100.00%

fpiapi's People

Contributors

msvilp avatar tcmug avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

fpiapi's Issues

Luottokunta -gateway does not work

I could not find the Service Description for the implementation since Luottokunta is changing their infosec policy 26.11.2012 and only provided me with the latest Service Description which uses sha256 instead of md5 and added security policies.

I rewrote the Luottokunta -gateaway and tested it and got it working, but you also should change the checkFields() -method to use $v == '' instead of empty($v) since some providers return 0 as status codes which does not pass empty() (Like Sampopankki)

gateaway.php:205

  public function checkFields(array $fields) {
    foreach ($fields as $k => $v) {
          /*
           * do not use empty() here since some providers use status code 0 as valid return code
           */
      if ($v == '') {
        return FALSE;
      }
    }
    return TRUE;
  }

And this is the refactored AND tested version of Luottokunta.php -gateaway:

<?php

/**
 * Gateway for Luottokunta
 * 
 * Refactored gateway to be compatible with the new rules of Luottokunta
 * Uses hash('sha256', $mac) instead of md5($mac) which is the new infosec-policy
 *
 */
class FpiapiGatewayLuottokunta extends FpiapiGateway {

    /**
     * Constructor
     */
    public function __construct() {
        parent::__construct();
        $this->name = "Luottokunta";
        $this->postUrl = 'https://dmp2.luottokunta.fi/dmp/html_payments';
        $this->hasPaymentAbility = true;
    }

    /**
     * getPaymentFields()
     * @see fpiapi/gateways/FpiapiGateway::getPaymentFields()
     */
    public function getPaymentFields() {

        $mac_fields = $this->getFieldArrayForRequest();

        $mac_str = implode("&", $mac_fields);
        $mac = hash('sha256', $mac_str);

        $fields = array(
            'Authentication_Mac'     => $mac,
            'Success_Url'            => $this->getReturnUrl(),
            'Failure_Url'            => $this->getErrorUrl(),
            'Cancel_Url'             => $this->getErrorUrl(),
            'Device_Category'        => $this->getDeviceCategory(),
            'Card_Details_Transmit'  => $this->getCardDetailsTransmit(),
            'Currency_Code'          => $this->getCurrencyCode(),
            'Merchant_Number'        => $this->configuration['publicKey'],
            'Order_ID'               => $this->transaction->getUid(),
            'Amount'                 => $this->getFormattedSum(),
            'Transaction_Type'       => $this->getTransactionType(),
        );

        return $fields;
    }

    /**
     * isPaymentCompleted()
     * @see fpiapi/gateways/FpiapiGateway::isPaymentCompleted()
     */
    public function isPaymentCompleted() {

        $params = &$_REQUEST;

        if (!isset($params['LKMAC'])) {
            return false;
        }

        $fields = $this->getFieldArrayForResponse();

        if (!$this->checkFields($fields)) {
            return false;
        }

        $mac_str = implode("&", $fields);
        $mac     = hash('sha256', $mac_str);

        return strtolower($mac) == strtolower($params['LKMAC']);
    }

    protected function getFieldArrayForResponse() {

        $fields = array(
            'Private_key'      => $this->configuration['privateKey'],
            'Transaction_Type' => $this->getTransactionType(),
            'Currency_Code'    => $this->getCurrencyCode(),
            'Amount'           => $this->getFormattedSum(),
            'Order_ID'         => $this->transaction->getUid(),
            'Merchant_Number'  => $this->configuration['publicKey'],
        );

        $LB_fields = array(
            'LKBINCOUNTRY',
            'LKIPCOUNTRY',
            'LKECI',
        );

        // Add LB-fields if they exist in reponse
        foreach ($LB_fields as $LB_field) {
            if (isset($_REQUEST[$LB_field])) {
                $fields[$LB_field] = $_REQUEST[$LB_field];
            }
        }

        return $fields;
    }

    protected function getFieldArrayForRequest() {

        $fields = array(
            'Merchant_Number'  => $this->configuration['publicKey'], 
            'Order_ID'         => $this->transaction->getUid(),            
            'Amount'           => $this->getFormattedSum(),
            'Currency_Code'    => $this->getCurrencyCode(),
            'Transaction_Type' => $this->getTransactionType(),
            'Private_key'      => $this->configuration['privateKey'],
        );

        return $fields;
    }

    protected function getFilteredSum() {
        return str_replace(",", ".", $this->transaction->getSum());
    }

    protected function getFormattedSum() {
        return round($this->getFilteredSum() * 100);
    }

    protected function getTransactionType() {
        return '1';
    }

    protected function getCurrencyCode() {
        return '978';
    }

    protected function getDeviceCategory() {
        return '1';
    }

    protected function getCardDetailsTransmit() {
        return '0';
    }

}

Sampopankki wont pass fieldChecks()

Sampopankki uses 0 as some of their return codes which does pass php's empty().
The gateaway is fully working besides this little issue and here is how i fixed it:

  /**
   * checkFields
   * Verifies that the rows in $fields have values
   */
  public function checkFields(array $fields) {
    foreach ($fields as $k => $v) {
          /*
           * do not use empty() here since some providers use status code 0 as valid return code
           */
      if ($v == '') {
        return FALSE;
      }
    }
    return TRUE;
  } 

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.