tcsaba101 / sg21 Goto Github PK

I have tried the cloud module separation.
I have left the IFTTT part in main.cpp as it is the ingredient of the original OS217.

I have difficulties with compilation of cloud.cpp, after a dozens of errors, two errors I can't handle.

"v" is declared some lines before, even used, then it happens.

http_callback is a function parameter and a function name in OpenSprinkler.cpp.
I tried some extern versions, stil doesn't work. Ideas?

I am out for an early skiing till Wednesday.

I can read emails and issues.

If any ideas, pls let me know.

I am thinking of the code development stages for the future.

As a lot of ESP32 based services still missing on the ESP platform (LCD, button, SD, network) I still have some code what I would develop in the Atmel environment and release for the OS community:
some more kind of log records
brushing SensorGroup code
LCD messages on sensor data and alams

Most of those can be migrated later to ESP32

The cloud module and network needs absolute different implementation.
I will implement the cloud module on the Atmel platform what Paolo launced.
I will do the further testing on Atmel platform, till the ESP network handling will get alive.

I think till the ESP services are not functional enough it is better if I develop on Atmel platform and we migrate those parts to ESP.

It will help me to get understood the ESP coding while I can brush the code.

How you think?

You have added a today write log routine!
void print_today_log(ulong days){
It is only for debug?
It is really necessary on ESP32 code?

Check_network has been modified from original 2.1.7 code . Since ESP32 do not have a ping function like Arduinos and ESP8266 the code need to be rewritten.
Could you tell me the reason for your changes and essential features you have added to this routine?
If necessary a logic diagram will be usefull.

Branch OS217_sensor prepared to release.

The cloud related code has been removed.

I will merge it vith original OS217, the clone to a sparate account/repository.

Then I will post on OS forum.

Any hints?

I cannot compile myself the branch ...... can you give me the compilation error messages?

I have seen you have done extensive modifications to NMV addresses , this may conflict with my previous one. This relocations are necessary because ROM Memory is very small on Arduinos and ESp8266.
But with ESP32 there is a new large NVM memory available that can be addressed easily .
I strongly suggest we use that NVM memory for all your parameters , CODING WILL BE MUCH SIMPLER !

All cloud related function from SG21 and OS 2.1.7 have been moved from main.cpp to cloud.cpp a new module I have added (BTW main.cpp was getting to large and complex!!)
We have to discuss more about all cloud related features we want to add to the ESP32 code so it is better to keep this as a separate task and complete first the implementation of sensor related parts.
Meanwhile it will be usefull to have a description of the new functions you have introduced and how they related to 2.1.7 IFTTT implementation.