team-resourceful / resourcefulbees Goto Github PK

Hello! I was testing out ResourceBees Mod with my own mods and had found that the ConfiguredFeature form of the Bee Nest Feature ( resourcefulbees:bee_nest_feature ) is not registered. This can be an issue for mod compatibility as under certain conditions, unregistered ConfiguredFeatures can basically prevent other mod's registered ConfiguredFeatures from spawning if in the same generation stage.

By that I mean, if mod A adds an unregistered CF to the ore generation stage and the biome's codec reaches it first, it will choke and basically nuke mob B's registered CFs afterwards. Here's a case where BetterCaves forgot to register their CF and caused several CFs from Oh The Biomes You'll Go to stop spawning in the world: YUNG-GANG/YUNGs-Better-Caves#75

Here's a more detailed explanation of why this happens in the biome's codec:

Specifically, when you call .withConfiguration on a Feature, you create a ConfiguredFeature. This is what should be registered to the WorldgenRegisties.

Here's an example from my mod RepurposedStructures of me registering all my ConfiguredFeatures in case you plan on adding more and want to see one way of organizing everything.
https://github.com/TelepathicGrunt/RepurposedStructures/blob/a4e3365e3867b8510952ebf658c415de6e412927/src/main/java/com/telepathicgrunt/repurposedstructures/RSConfiguredFeatures.java#L184-L185

I hope this helps!

Vanilla Bees dont go into vanilla hives and nest due to us adding them to our POI, remove them from our POI and add the vanilla poi to our find near by nests method

Is your feature request related to a problem? Please describe.
Not really.

Describe the solutions you'd like

• If configured, some bees can emit light. I know moving light sources has always been a problem to pull off, so I understand it might not be feasible. But if not, maybe bees could have some kind of effect similar to the enchanted item effect, possibly with color variants like Quark runes? I think the glowing potion effect would be kinda weird, but the ability to give bees potion effects in general might be neat!

• Spawn blocks: in addition to biome spawning, perhaps make it so a bee can only spawn on a certain block type? E.g. Wither Bees could be set to only spawn on Nether Bricks, so you'd only see them around Nether fortresses. Could also consider spawning based on registered structures, like minecraft:fortress?

• sizeModifier: I saw this parameter in the coal bee file, so can this can be used for any of them?

• Individual bee spawn weights: this seems like something you are probably already planning on, but thought I'd mention it. I know a kind of weighting can be achieved with the allowed biomes if anything.

Thanks for your consideration!

Just crafted bee jars do not stack with jars that have been used once. A metadata thing?

Resourceful Bees 1.16.1-0.3.2a

https://paste.ee/p/1tP66

using forge 31.2.4

Problem: Spent hours looking, never found coal bee, cheated spawn egg in. Coal bee never grew.
-used on multiplayer server
-only seem to have an issue with coal bee, haven't found a single other issue.

Describe the bug
The Bees Editor text is cut off in certain places.
My screen resolution is set to 1366 x 768.

To Reproduce
Steps to reproduce the behavior:

1. Set resolution to 1366 x 768
2. Go to Bees Editor
3. See error

Expected behavior
Clear text, with no cut offs.

Screenshots

Minecraft Version: 1.15.2
forge-31.2.5
Resourceful Bees Alpha - 0.2.0

Hello!

I'm testing out a bunch of mods on a local world, and my client has crashed a couple times. The crash reports list Resourceful Bees and a getRandomBee(BeeInfo.java:42) event. But I have quite a few mods, so maybe it's some interaction between this one and another. Any thoughts or suggestions are welcome!

Oh, and I have not made any custom bees - all configs are default. And I have seen many of the bees from this mod in the world, e.g. skeleton bee, redstone bee, gold bee, etc.

crash-2020-05-25_17.47.37-server.txt
crash-2020-05-25_14.47.06-server.txt

Thanks for any help you can provide!

Description:
When using the GUI for the Centrifuge Multi-block, shift-clicking honeycombs and honeycomb blocks are not jumping into the third (right most) location. Dragging honeycombs and honeycomb blocks into the location does allow the position to work.

Version Information:

• Forge Version 31.2.36
• ATM 5 - Mod Version 2.21
• Resourceful Bees Version 1.15.2-0.3.8a

Crash when multiblock centrifuge is full

I'm feeding cob block into a chest. A Mekanism's logistical transporter is spliting them onto two multiblock centrifuges (they're side by side)
I believe the error arises when the centrifuge output buffer gets full, but can't confirm it because the crash happens too fast. The error refers to the slot 22
Maybe It doesn't like the hopper chain...

Expected behavior
It should stop processing it the output buffer is temporarily full

please complete the following information:

• Forge Version 32.0.108
• Mod Version resourcefulbees-1.16.1-0.3.8a

crash-2020-10-09_02.47.16-server.txt

Bees created with the bee editor don't spawn in world due to the biomeList being incorrect. we need to add a field for biome whitelist and biome blacklist

Describe the bug
Auto generated comb block recipes don't respect mainInputCount.

To Reproduce
Check JEI or put a comb block in the multiblock centrifuge.

Expected behavior
64 Comb blocks should equal 9 netherite in my example image.

Screenshots
(Additionally tested by putting comb block in centrifuge multiblock)

• Forge Version 32.0.108
• Mod Version 1.0.3.9a

Customize bee models

If I set up the JSON file like below, I would expect the bee to both set me on fire, and give me the wither effect. However it only sets me on fire. It also appears that the bees made with this file have an issue with their hitbox (I am unable to damage them with a sword, or by using splash potions). Trying the same thing with pigman bee and wither bee gives only one effect as well.

{
"color": "#444444",
"flower": "minecraft:wither_rose",
"baseBlock": "minecraft:bedrock",
"mutationBlock": "minecraft:dirt",
"mainOutput": "minecraft:charcoal",
"spawnInWorld": true,
"biomeList": "tag:NETHER",
"maxTimeInHive": 600,
"witherBee": true,
"blazeBee": true,
"netherBee": true,
"breedable" : true,
"parent1": "Wither",
"parent2": "Diamond"
}

Hello! Just found an issue where if the original 14 bees are tweaked or adjusted the changes do not save and get reset after loading up minecraft to the original state. I'm trying to create a tier style breeding system using your bees and dont want gold, diamond, etc to spawn freely around the world but to be bred instead.

Is your feature request related to a problem? Please describe.
Vanilla bees cannot breed with resourceful bees, vanilla bees cannot use beehives from this mod, and resourceful bees cannot use vanilla beehives.

Describe the solution you'd like
Vanilla bees should be able to breed with resourceful bees and they should be able to use each others' beehives. It should be possible to define vanilla bees as one of the parents when defining a custom bee species.

All Honeycombs ID and Tags are the same. This causes other mods to consider different honeycombs to be the same. Therefore, when auto sorting or using a item movement system, they can't move different types to different locations. Please add different tags and different IDs to each honeycomb (possibly the honeycomb blocks) to fix issues.

• Forge Version 31.2.36
• ATM 5 - Mod Version 2.21
• Resourceful Bees Version 1.15.2-0.3.8a

I am not sure if this is intended but glass bottles get filled into every slot of the centrifuge not just the left one where they are supposed to be.

Describe the bug
After creating the first bee, if the Breedable box was previously checked, I cannot input parent names. If the box is then unchecked, I can input parent names. Same with the biome list.
I had to refresh the page to fix it.

To Reproduce
Steps to reproduce the behavior:

1. Create a new bee with both Breedable and Biome list checked.
2. Create a second bee
3. Try to input new parents/biomes.
4. See error

Expected behavior
If checked, appropriate boxes should be enabled.

This is something you can work on Dark

Currently not compatible with Fluid -> Fluid transformations or Block -> fluid transformations. Needs to be added/implemented.

{ "color": "#5dbcd2", "flower": "minecraft:nether_wart", "baseBlock": "minecraft:netherrack", "mutationBlock": "minecraft:magma_block", "mainOutput": "minecraft:blaze_rod", "spawnInWorld": true, "biomeList": "tag:NETHER", "maxTimeInHive": 600, "certusBee": true }

My problem is that the name of my bee and the colour is not correctly displayed and i do not know how i can fix that because i have only used the example code and only changed the name of the bee.

Figure out if the family tree map is empty or what is causing the category to display empty on /reload. Also determine if other categories are affected.

Netherite bee can't pollinate wither rose without getting wither effect. then it dies.

Is your feature request related to a problem? Please describe.
Its very frustrating that the new json style isn't in the wiki

Describe the solution you'd like
I want that the new json format is also in the wiki.. pls

Describe alternatives you've considered
Using the json used in the default bees. its aids

Describe the bug
I've customized the default bees. I checked their syntax against the (updated) wiki, and made a bee with the new bee creator web page to compare against also. (The web page puts numerical values like the size modifier and output weights in quotes, fwiw - doesn't resolve my issue regardless.) I've made a test profile with no other mods except JEI, TOP, and other client-side GUI mods - along with this mod. Still no bees. I removed biome restrictions for many of them, just to have a better chance of seeing them spawn...somewhere. Nada.

If I leave every config in this mod untouched, I get the default bees all day long. But the whole point of the mod is to make custom bees, yeah? But when I do that, I never see the custom bees spawn in the world. No nests. No bees. Nothing. I see the logs saying "X bee passed validation check!" for all my bees. But where are they? I can spawn them manually from the "egg" item. I can see their honeycombs and honeycomb blocks in JEI and hold/place them. I didn't lower the global spawn weight. I triple-checked that spawn in world equals true. I'm at a loss.

Here's my latest stripped-down version of my custom bee configs, including the latest log:

https://www.dropbox.com/sh/vja1mcq7mqdmzid/AAButbX3d6pS7HMTpZ8qqlBza?dl=0

To Reproduce
Steps to reproduce the behavior:

1. make custom bee(s)
2. load world
3. look for said bee(s)
4. give up

Expected behavior
bees spawn naturally, as nature intended

Screenshots
n/a

please complete the following information:

• Forge Version 1.15.2 - 31.2.9
• Mod Version 0.2.4a

Additional context
bees

Thanks.

I just don't know how to anything with this Mod. I can't find any guides that tells me how to breed or get specific bees and i am completely lost.

With a Proper Wiki or Guide (maybe even In game guide using Guide API's) players can progress much better with this mod.

A Video or a Wiki even a Guidebook is all I need.

Is that possible or even in work, or am I just too stupid to play this mod?

Describe the bug
If you create an multiblock apiary and let it run (I had in a chunkloaded area but I was in it) with bees, it crashes after some time.

To Reproduce
Steps to reproduce the behavior:

1. Start multiplayer server
2. Make multiblock apiary and fill it with bees.
3. Wait some time and have fun.
4. Multiplayer server crashes

Expected behavior
It shouldn't crash

Error

net.minecraft.crash.ReportedException: Ticking block entity
        at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:851) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
        at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:283) ~[?:?] {re:classloading,pl:accesstransformer:B}
        at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:783) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
        at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:638) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
        at net.minecraft.server.MinecraftServer.lambda$func_240784_a_$0(MinecraftServer.java:229) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_262] {}
Caused by: java.lang.NullPointerException
        at com.resourcefulbees.resourcefulbees.tileentity.multiblocks.apiary.ApiaryStorageTileEntity.deliverHoneycomb(ApiaryStorageTileEntity.java:199) ~[?:1.16.3-0.5.3b] {re:classloading}
        at com.resourcefulbees.resourcefulbees.tileentity.multiblocks.apiary.ApiaryTileEntity.releaseBee(ApiaryTileEntity.java:192) ~[?:1.16.3-0.5.3b] {re:mixin,re:classloading}
        at com.resourcefulbees.resourcefulbees.tileentity.multiblocks.apiary.ApiaryTileEntity.tickBees(ApiaryTileEntity.java:317) ~[?:1.16.3-0.5.3b] {re:mixin,re:classloading}
        at com.resourcefulbees.resourcefulbees.tileentity.multiblocks.apiary.ApiaryTileEntity.func_73660_a(ApiaryTileEntity.java:289) ~[?:1.16.3-0.5.3b] {re:mixin,re:classloading}
        at net.minecraft.world.World.func_217391_K(World.java:491) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A}
        at net.minecraft.world.server.ServerWorld.func_72835_b(ServerWorld.java:366) ~[?:?] {re:classloading,xf:fml:immersiveengineering:IE block update callback,pl:runtimedistcleaner:A,re:mixin,pl:runtimedistcleaner:A}
        at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:847) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}

• Forge Version [e.g. '1.16.3 - 34.1.18']
• Mod Version [e.g. '0.5.3b']

Need to add more pics and verbiage regarding our added items/blocks.

Add info discussing our breeding and mutation mechanics and how they work.

Add clarifying information regarding Lang files.

Is still not understand how every feature works (how to breed bees for ex)
So a guide maybe in form of a book that explains some features of the mod would be realy helpfull.
There is not much to say about this. I thought it would be really helpfull for people that are new to the mod like me to learn it.

What the title says

Line 26:
BeeData bee = BeeInfo.getInfo(entitylivingbaseIn.getBeeType());

Needs to be changed to:
BeeData bee = entitylivingbaseIn.getBeeInfo();

Doesn’t change what happens or what data is obtained. Just needs to be updated for consistency.

test

Slime Bees, Blaze Bees, and Glowstone Bees do not produce honeycomb when given blocks and flowers.

Slimy Bees were given various flowers (Minecraft and other Mods), a Slime Block, and a Lily Pad with no effects toward producing any Slimy Honeycombs. Blaze Bees were given various flowers (Minecraft and other Mods), a Blaze Mesh (from Botania), Nether Quarts Block, Glowstone, Nether Wart, Netherrack, and Nether Brick with no effects toward producing any Blaze Honeycombs. Glowstone Bees were given various flowers (Minecraft and other Mods), Glowstone, Glowstone Lamp, Nether Wart, Netherrack, and Nether Brick with no effects toward producing any Glowing Honeycombs.

The bees never were attached to anything unlike other bees where they dance around the blocks/flowers. The bees never increased the level of the hive based on comparator signal. The Bees were by themselves with no other Bee interaction.

In JEI, no images show up for either Slimy, Blaze, or Glowing Bees under the Bee Flower tab. (image attached)

It makes sense to have the Slimy Bee be a slime block, the Blaze Bee to be nether wart, and the Glowing Bee to be glowstone.

please complete the following information:

• Forge Version 31.2.36
• All the Mods - Mod Version 2.21
• Resourceful Bees Version - 1.15.2-0.3.8a

Describe the bug
When using the multiblock centrifuge and feeding it bottles as well as honeycombs the two first input slots for honeycombs fill up with glass bottles.

To Reproduce
I am in ATM6 and using Refined Storage to fill the centrifuge using an exporter configured to move glass bottles and honeycomb blocks.

Expected behavior
Expected behavior would be that bottles only go into the bottle slot on the left of the UI

Screenshots
https://imgur.com/a/asyEess

please complete the following information:

• Forge Version :I do not know how to find this information :(
• Mod Version :resourcefulbees-1.16.1-0.3.8a

Additional context

Is your feature request related to a problem? Please describe.
It takes a lot of time to make lang files for the bees.

Describe the solution you'd like
Have a line in the json for the bee "name": "Name Here" to make auto generated lang file for the bees/items based on what was put in.

Additional context
Repeating this process isn't fun

Describe the bug
When the Wither Bee is added to the Apiary, the game crashes on rendering the ValidatedApiaryScreen.

To Reproduce
Steps to reproduce the behavior:

1. Create an apiary (I used t4 apiary, 1 apiary_storage, and oak planks. Interior of the Apiary was dirt on top of bottom planks and flowers on top of dirt.
2. Use the bee spawner to spawn bees until you get a wither bee.
3. Capture the Wither Bee in an Apiary Jar
4. Import the Wither Bee into the Apiary
5. See the game crash.

Expected behavior
Wither Bee is added to apiary inventory as locked bee

Crash Report:
crash-2020-08-18_00.33.26-client.txt

please complete the following information:

• Forge Version 1.16.1 - 32.0.108
• Mod Version Resourceful Bees 1.16.1-0.3.7a

Describe the bug
Game crashes if centrifuge output is too full.

To Reproduce
Steps to reproduce the behavior:

1. Build multiblock centrifuge
2. Add a lot of coal comb blocks
3. Wait a few seconds
4. Crash

Expected behavior
Machine stops working if output is too full.

please complete the following information:

• Forge Version 1.16.3-34.1.0
• Mod Version 1.16.3-0.5.1a

Additional context
Crash log: https://pastebin.com/EEygvbxJ

Need to investigate and figure out why TOP doesn't work properly with dedicated servers.

on the newest version there seems to be a bug with the multi block centrifuge, importing glass bottles are moved into both the glass bottle spot along with placing them in the 1st and 2nd honey comb slots

isGlowing
glowingColor -> rename to glowColor before release
isEnchanted
feedItem
feedAmount
mainInputCount
attackDamage
spawnWeight

Will be adding a mutationCount to override the default of 10

Is your feature request related to a problem? Please describe.
Currently, bee types are limited

Describe the solution you'd like
If Breedable is enable for a bee, allow the parents to have a random bee type output. This could allow for more flexibility.

Describe alternatives you've considered
None that I can think of at the moment.

123

Describe the bug

• Renaming default bees does not display their name correctly in-game, as indicated in the screenshot. (In this example, I changed Coal.json to Sooty.json and Skeleton.json to Skeletal.json.) Also, their associated honeycombs/blocks are named incorrectly in JEI.
• New custom bees are not spawning in the world. (Attached their json files for review.)

To Reproduce
Steps to reproduce the behavior:

1. Set generateDefaults = false in resourcefulbees\common.toml.
2. Rename default bee json file (e.g. Gold.json to Golden.json).
3. Create new bee json file.
4. Bump up spawn weight to find bees more quickly, since idk how to summon any but the default bee.
5. Check JEI for associated honeycombs/blocks.

Expected behavior

• Customized bee names and associated honeycomb/block names display in-game properly.
• New custom bees should spawn in the world, and their honeycombs/blocks should be displayed in JEI.

Screenshots

please complete the following information:

• Forge Version: 1.15.2 - 31.2.5
• Mod Version: 0.2.2a

Additional context

I followed your surprisingly good wiki (sorry, such a rarity these days), and I feel like my configs are correct. But I could've easily missed something, so any feedback is welcome. One thing I just noticed is the default bee files have mutationInput and mutationOutput as parameters, whereas I configured my new bees going by the wiki, which doesn't mention those but instead mentions baseBlock and mutationBlock. Would changing the files to use the input/output parameters maybe fix those new bees at least?

Custom bee files:
bees.zip

It would be a nice feature if you could choose which texture to use for a bee. Consider a world where there a multiple bees with the bee trait "Pigman Bee". It would be nice to distinguish them somehow. The same logic goes for Wither Bees, Creeper Bees, ZomBees. Maybe it is possible to somehow separate the textures from the special traits given to the bees.

I would like the bee effects pages to open by clicking with JEI ("U" button) on the bee spawn eggs

Is your feature request related to a problem? Please describe.
Currently the comb block recipes output in large chunks rather than 9 rolls of one comb recipe, which makes especially rare outputs even rarer than using combs.

Describe the solution you'd like
Comb block recipes should output 9 separate rolls of their outputs rather than 1 roll for 9 of the outputs.
I would like this more as it allows for especially rare outputs to be rolled in a balanced way.

Describe alternatives you've considered
Currently comb blocks roll for 9 of an output, which is alright, just not what I expected the behavior to be.

Investigate "Could not deserialize minecraft:" console log.

Describe the bug
While on my server, the server crashed because of a Grass Bee Nest that probably generated nearby. Not sure how to reproduce the crash or what caused it.

To Reproduce
Steps to reproduce the behavior:

1. Load a world
2. Crash?

Expected behavior
No crashes

please complete the following information:

• Forge v31.2.5
• Resourceful Bees v0.2.4a

Additional context
Crash Report

make it look like mario Boos and change behavior to stop and cover eyes when looked at.