team5593 / tau2016

2016 Robot Code

τ 2016

2016 Robot Code.

tau2016's Issues

Custom Functions

Be aware that in your CustomFunctions.h abs(rawAxis) will return an int http://www.cplusplus.com/reference/cstdlib/abs/ which isn't ideal when checking against a float Use fabs instead http://www.cplusplus.com/reference/cmath/fabs/.

I'd recommend not over-engineering the code by creating simple functions. The extra lines of code will mean extra maintenance. For example you could probably replace the Sign function with the ternary operator:

int sign = (input < 0) ? -1 : 1;

If you do really need the 0 condition then the Sign function is probably warranted as doubling up the ternary operator gets a bit difficult to read, another very important facet of coding when you have to understand it in 6 months time:

int sign = (input < 0) ? -1 : (input > 0) ? 1 : 0;

Aaron