teamdandelion / chartographer Goto Github PK

Chartographer.version should be defined

Should version of chartographer be linked to specific versions of plottable, or is specifying a minimum version preferable?

currently it is:

"dependencies": {
"plottable": "0.35.0"
},

while plottable 0.39.0 is available.

It's using v0.35.0 instead of v0.39.0
upgrade it

Not sure if this is an error in Chartographer, Plottable, or just the demo, but this file examples/line.html has this error in the console.

Uncaught Error: xScale needs to inherit from Scale.AbstractQuantitative
    Gridlines 
    Chart.getComponents
    Chart.renderTo
    window.onload

It seems to be because xScale is an Plottable.Core.Ordinal but that class does not inherit from Plottable.Core.AbstractQuantative. Again, not sure if this in an error somewhere in the library or just bad usage in the example.