teamjm / journeymap-legacy Goto Github PK

The current situation

Currently, waypoints on a server are stored client-side in:

.minecraft/journeymap/data/mp/<server name>_<world_id>/

where <server_name> is the name that the user has typed in to identify the server in their server list (with spaces replaced by ~s); and <world_id> is the world ID on the server side* (with dashes replaced with ~s)

This has the consequence that if either there is a server update that doesn't carefully preserve the journeymap config; or the client changes the human-readable name in the server list; none of the user's old waypoints will show up anymore. This clearly seems like the worst of both worlds (pun unintended) to me. If waypoints are intended to be associated with a given server-side world id, changes to display names on the client side shouldn't make the waypoints go somewhere totally different. The human-readable part of the filename is helpful in fixing the situation, but it would be just as good to have a "client-side-server-name.txt" inside the folder.

Proposal

Categorize server waypoints based on either the world ID alone, or maybe the server address. Maybe save the client-side human-readable name in a text file.

Footnote (maybe this should be another ticket)

* Confusingly, JM seems to create two files in <server root>/config/JourneyMapServer/:

World.cfg, starting with

{
  "WorldID": "<the actual world_id>",

and <world_id>.cfg, starting with

{
  "WorldID": "<some other random hex string (?!)>",

I have no idea which of these is actually used, and I'm too scared of messing up everyone's waypoints to mess around and find out.

It's very tedious to have to manually swap out a client-side mod in a modpack (e.g. GTNH) to either get to see other players and mobs on a server, or to comply with a server policy of not getting that. Architecturally, it would make much more sense to me for this to be a server-side setting--have a config file that determines whether players connecting to the server get the "unlimited" or "fairplay" experience.

This is just a suggestion for anyone who might work on the project, but there is a nice feature in later versions of journeymap to automatically toggle between day map and night map based on day time.

This is a page where you can see the configs.
https://teamjm.github.io/journeymap-docs/latest/Client%20Docs/settings/minimap/

cheers.

most biomes o plenty tall grass shows up as grey on the minimap if show plants is enabled

snow is also invisible on the minimap(but not always?) could be because i'm using journeymap, and it may only happen at certain altitudes since if i break the block below and place it 1 block lower it appears on the minimap but if i place the block above again and place the snow at the same altitude it was it doesnt show up again



breaking the snow fixes it

using angelica a34
using journeymap 1.7.10 514p8
BiomesOPlenty-1.7.10-2.1.0.1860-universal.jar
i am aware my bop is slightly out of date but its the last version to include some textures i like that were changed in later 1.7 versions.

I downloaded the code, compiled and I get the "journeymap-1.7.10-5.9.4-fairplay.jar" and "journeymap-1.7.10-5.9.4-unlimited.jar", I paste this two files in my ".minecraft/mods" but when I load the mod is not recognize: