teb-model / teb Goto Github PK

To allow more compatibility with other models and given dmey/minimal-dx#2, change the current default behaviour that promotes unqualified real to real(8) optional and make unqualified real the default option at compile time.

Before merging into master, test that MinimalDX produced sensible results.

Need to add integration tests for comparing TEB (make v cmake) to CI and refactor to run together with tests for MinimalDX.

• Update installation instruction (ninja)

In bem_morpho.F90 the number of floors is calculated correctly but then rounded to the closest integer before being converted again to real -- see code below:

@VakankGrang @ValeryMasson is there any reason for doing this instead of keeping at as real? This is useful when average building values are used.

In driver.F90 the canyon humidity ZQ_CANYON is reported as humidity ratio but this does not seem to be consistent with what reported in readme and in other files. ZQ_CANYON should be specific humidity and not humidity ratio.

https://github.com/dmey/teb-model/blob/b54a2272ab8a0fc83b8cab38d6dcf40d018e6f26/src/driver/driver.F90#L255

Need to confirm if this is a typo or an actual inconsistency.

@VakankGrang these look like some old file headers that are not used anywhere. If that is the case are we OK to remove them?

./src/teb/consphy.fh
./src/teb/impnone.fh
./src/teb/stabfunc2.fh
./src/teb/surfcon.fh