technomancy / server-socket

Clojure server-socket library spun off from monolithic contrib

server-socket

Server socket library from clojure-contrib, spun out into an independent library for compatibility with Clojure 1.3.

License

Copyright © Craig McDaniel, Jan 2009

Distributed under the Eclipse Public License, the same as Clojure.

server-socket's Issues

disconnected/dropped clients become orphaned threads

(defn mysocket [in out]
  (loop []
    (prn "still here" in)
    (Thread/sleep 1000)
    (recur)))

(defn startserver [] (create-server 1234 mysocket))

How could I shut these down properly?

non SocketExceptions in the handler leave a dangling open socket / client

In the following code
(defn- accept-fn [^Socket s connections fun](let [ins %28.getInputStream s%29
outs %28.getOutputStream s%29]
%28on-thread #%28do
%28dosync %28commute connections conj s%29%29
%28try
%28fun ins outs%29
%28catch SocketException e%29%29
%28close-socket s%29
%28dosync %28commute connections disj s%29%29%29%29))

We should probably have something more like
...
(try
(fun ins outs)
(catch SocketException e)
(finally (close-socket s)))
...

This way if the handler raises any kind of exception, the socket is still closed and the client disconnected - allowing it to establish a new connection.