ted537 / cmpe327 Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 2.0 574 KB

License: MIT License

Python 82.88% HTML 11.62% Dockerfile 0.19% Shell 5.31%

cmpe327's People

Contributors

Watchers

Forkers

16cmc21 joshua-neizer

cmpe327's Issues

update_post() error pages will never be seen

cmpe327/qa327/frontend.py

Lines 184 to 206 in d68f5ca

 def error_page(msg): 

 """ 

  Render error message on index page. 

  :param msg: text of the error message 

  :return: default page with error message 

  """ 

 flash(msg) 

 return redirect('/', code=303) 

 prev_ticket_name = request.form.get('update-prev-ticket-name') 

 upt_ticket_name = request.form.get('update-upt-ticket-name') 

 ticket_quantity = request.form.get('update-ticket-quantity') 

 ticket_price = request.form.get('update-ticket-price') 

 ticket_expiration_date = request.form.get('update-ticket-expiration-date') 

 is_blank = { 

 'name': len(upt_ticket_name) == 0, 

 'quantity' : len(ticket_quantity) == 0, 

 'price' : len(ticket_price) == 0, 

 'exp-date' : len(ticket_expiration_date) == 0 

 } 

 if not bn.get_ticket(user.id, prev_ticket_name): 

 error_page("Ticket doesn't exist")

error_page() returns a value; it has no side effect. Calling the function does nothing. Should use return error_page('your message here') instead.

Note: this is an implementation detail fix, it is not necessary for A4 as correctness will be fixed up in A5.

R5 Testing

Implement frontend tests for R3

Use Library for Email Validation

https://github.com/CISC-CMPE-327/Information/issues/54#issuecomment-716935513

Apparently, we are allowed to use third-party libraries, and this will make our codebase simpler. This should eliminate is_valid_local_part() and other specific methods.

Pip install this or similar
Check regex ony check_regex=True (do not ping SMTP check_mx=False)
Add new dependency to requirements.txt
Update design doc table

Implement frontend tests for R2

Check over R4 /sell

Check that all requirements are satisfied

Implement frontend tests for R1.7 to end of R1

Create test case for one backend method unit

See requirements

Update program description in design.md

Connect services with docker compose

Build docker image

R6 Testing

Integration testing

Rapidly Implement R5 /update

Implement all requirements specified in R5

Implement frontend tests for R1 up to R1.6

Add new methods and files to Function Descriptions table in design docs - Colin

Backend White-box testing

Complete R4 Testing

Update program diagram in design.md

Rapidly Implement R6: /buy

Implement all requirements within R6

	def error_page(msg):
	"""
	Render error message on index page.
	:param msg: text of the error message
	:return: default page with error message
	"""
	flash(msg)
	return redirect('/', code=303)

	prev_ticket_name = request.form.get('update-prev-ticket-name')
	upt_ticket_name = request.form.get('update-upt-ticket-name')
	ticket_quantity = request.form.get('update-ticket-quantity')
	ticket_price = request.form.get('update-ticket-price')
	ticket_expiration_date = request.form.get('update-ticket-expiration-date')
	is_blank = {
	'name': len(upt_ticket_name) == 0,
	'quantity' : len(ticket_quantity) == 0,
	'price' : len(ticket_price) == 0,
	'exp-date' : len(ticket_expiration_date) == 0
	}

	if not bn.get_ticket(user.id, prev_ticket_name):
	error_page("Ticket doesn't exist")

ted537 / cmpe327 Goto Github PK

cmpe327's People

Contributors

Watchers

Forkers

cmpe327's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs