GithubHelp home page GithubHelp logo

Comments (17)

macdja38 avatar macdja38 commented on May 18, 2024

How are you requiring/importing deepmerge?

from deepmerge.

TehShrike avatar TehShrike commented on May 18, 2024

Are you using bower? is-mergeable-object isn't on bower...

from deepmerge.

TehShrike avatar TehShrike commented on May 18, 2024

I'm not sure exactly what issue you were having, but I published 1.4.3 to inline is-mergeable-object for folks using bower who are trying to bundle the CommonJS entry point.

Let us know what your environment is @smarbiv, and whether or not 1.4.3 works for you.

from deepmerge.

smarbiv avatar smarbiv commented on May 18, 2024

Thanks for your quick response.
Yes, we do using bower and unfortunately the fix didn't solve the problem because when bringing it with bower the 'is-mergeable-object ' does not included..

from deepmerge.

TehShrike avatar TehShrike commented on May 18, 2024

1.4.3 no longer relies on you downloading the is-mergeable-object module - the code is inlined in every version of the file that is distributed on the npm registry.

Does bower not use the npm registry? Does it require that the built files be on Github? I'm not familiar with bower's workings at all.

from deepmerge.

TehShrike avatar TehShrike commented on May 18, 2024

hmm, at the very least, it looks like I forgot to update the main field in the bower.json

from deepmerge.

smarbiv avatar smarbiv commented on May 18, 2024

Hi,
Bower uses tags, downloads the library and uses the main file you defined in your bower.json (in your case this is index.js). But this index.js is from your source code which is not packed with 'is-mergeable-object', so this is the reason why we can't use 'deepmerge' with bower..

from deepmerge.

TehShrike avatar TehShrike commented on May 18, 2024

I published 1.4.4 with an updated bower.json, let me know if that works for you.

What bundler are you using?

I didn't think to ask this when Bower was discussed before, but I'm curious what bundlers look at bower.json at all.

from deepmerge.

TehShrike avatar TehShrike commented on May 18, 2024

I'll assume everything is fine and dandy now :-)

from deepmerge.

smarbiv avatar smarbiv commented on May 18, 2024

Hi,
Sorry for the late response.
Unfortunately it didn't fix the issue.
We use bower to bring the package (using the git endpoint: "deepmerge": "https://github.com/KyleAMathews/deepmerge.git") and webpack for packing.
Because the 'dist' folder does not included in the git, the fix which use 'dist/umd.js' as the main file doesn't work for me.
Meanwhile we are using an older version of your module (1.3.2)

from deepmerge.

TehShrike avatar TehShrike commented on May 18, 2024

Could you depend on the unpkg link? https://unpkg.com/deepmerge/dist/umd.js

from deepmerge.

smarbiv avatar smarbiv commented on May 18, 2024

Yes, that works for me! :)
Thank you very much for all your help!

from deepmerge.

TehShrike avatar TehShrike commented on May 18, 2024

I wonder if there's something I could put in the bower.json that would save other bower users from running into this

from deepmerge.

smarbiv avatar smarbiv commented on May 18, 2024

Your fix in 1.4.4 could work if the file was exists, so adding the dist folder with the umd.js file to git maybe could be a solution..

from deepmerge.

TehShrike avatar TehShrike commented on May 18, 2024

Is bower support worth adding build artifacts to the repository?

from deepmerge.

TehShrike avatar TehShrike commented on May 18, 2024

I'm leaning towards no :-x

from deepmerge.

TehShrike avatar TehShrike commented on May 18, 2024

Merging #69 will officially drop Bower support via the Github repo.

from deepmerge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.