telefonicaid / logops Goto Github PK

logger.debug("test", undefined) fails with [email protected]. It tries to call undefined.toJson()

Related to #13 and reported by Ivan (@grezue).

I am using this library for an app that serves web pages. I am interested in logging the requests sent to my "functional" endpoints but I really don't want to log each and every request that the browser sends to get static content (images, css, javascript, etc). Would it be possible to disable logging for specific paths?

If there is not a context, don't log a null trans/corr/op in the JSON formatter. Omit those fields instead.

This way, you can choose in execution time what log level the app should use

Allow not prefixed context properties

logger.info({some: 'value'}, 'This is %s', 'Sparta');
// {"time":"2015-06-23T10:13:49.879Z","lvl":"INFO","some":"value","msg":"This is Sparta"}

Related to #5

A logger.setLevel('OFF') or logger.stream = null would make it easier to disable logs.
I'd prefer the logger.stream = null alternative. Do you accept pull requests for this?

As #36 discussion says, we are going to start working in the v2 release to address Breaking changes from node v6 that we have inherited

• Make master node < 6 compatible. Bump 1.0.8 [#38]
• Create release/1.X branch and 1.0.8 tag
• Set master to be v2 code, only with node > 6 compatible code [#39]
• Release 1.0.8
• Set deprecation notice in npm v < 1.0.7
• Bump and Release 2.0.0

So each one can have its own behaviour regarding to which context should use.

Use case for express

const app = express();

app.use((req, res, next) => {
  req.logger = logops.child({
    getContext() {
      return { 
        transactionId: uuid.v4()
     }
  };
  next();
});

app.use((req, res, next) => {
  req.logger.info('With request specific context!');
})

Tests are failing for node6, mostly for some changes in how dates and errors are now default printed by util.format

When op/corr/trans is not available, use the "standard" "NA" instead of "n/a". This should go to 1.x because it could break backwards compatibility.

With [email protected] logger.info("test", 1, 2)fails with:

TypeError: Object.keys called on non-object
    at Function.keys (native)
    at /private/tmp/node_modules/logops/lib/formatters.js:158:12
    at Array.forEach (native)
    at Object.formatJsonTrace [as format] (/private/tmp/node_modules/logops/lib/formatters.js:156:8)
    at logWrap (/private/tmp/node_modules/logops/lib/logops.js:76:15)
    at repl:1:9
    at REPLServer.self.eval (repl.js:110:21)
    at Interface.<anonymous> (repl.js:239:12)
    at Interface.emit (events.js:95:17)
    at Interface._onLine (readline.js:203:10)

The user should use placeholders, but logops should handle that case and not crash in any case.

The usage seems much more difficult than it is. I think that:

• dev info (grunt, lint, test...) should be moved to a different .md file
• advanced usage tips (context, delegated context support, customization, advanced writing to files) could go to different .md files
• context vars (corr, trans, op) are telefonica specific and shouldn't be included by default in this module (that could wait for a 1.x release if it breaks backwards compatibility). I think that formatter could be moved to a logops-tef or something like that.

Add typings for logops (see https://github.com/typings/registry)