telus / ansible-aws-infrastructure Goto Github PK

TASK [telusdigital.aws-infrastructure : include] *******************************
[DEPRECATION WARNING]: ec2_ami_search is kept for backwards compatibility but usage is discouraged. The module documentation details page may explain more about this rationale..
This feature will be removed in a future release. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
included: /private/etc/ansible/roles/telusdigital.aws-infrastructure/tasks/create/instance.yml for localhost

I know in some places we use 443 but that's not consistent when the application is using 443 for HTTPS. I noticed that in most cases the sshd_config has both 22 and 10443 but the security group only have 22 and 443. We might just need to align this.

Whenever -e autoscale=True is called it creates a new launch configuration. However, it doesn't clean up after itself. We should add a task to clean old launch configs.

Hey everyone,

I noticed that the Custom TCP rule for the -application Security group that's assigned to nodes has port 81 fully open, which is used for the auto deploy hook. Since we now have all our code on Github, what do you think of restricting it to 192.30.252.0/22 which is the CIDR for Github.

Rob

There should be a when clause defaulting to no

This does not consider VPC peering connections. It will break VPC peering connections whenever run. We need to fix that.