GithubHelp home page GithubHelp logo

Comments (16)

xawill avatar xawill commented on June 17, 2024 1

I didn't investigate at all, but I saw you use OffscreenCanvas a lot. This is still considered an experimental feature, is not supported by Safari and only partially by Firefox : https://developer.mozilla.org/fr/docs/Web/API/OffscreenCanvas.

from geo-three.

tentone avatar tentone commented on June 17, 2024 1

@xawill That could be the reason for the height data to be missing.

I will patch the lib to use regular canvas object whenever OffscreenCanvas is not available.

Thanks a lot!

from geo-three.

tentone avatar tentone commented on June 17, 2024

Hello

The library supports 3D terrain tiles it is the main focus in this library.

You can open the example of the library and switch between modes and tile providers to experiment the multiple configurations.

Thanks a lot!

from geo-three.

xawill avatar xawill commented on June 17, 2024

Thank you for your reply.

I think the issue is with the demo at https://tentone.github.io/geo-three. Try to load the page and check the console. A lot of "Failed to load height node data" errors display. I guess that we cannot test the 3D part of your library on the demo website due to this.

But most likely the issue is due to an error in authentication with MapBox height tiles server or something on the demo. I'll give it a try locally with my own tiles providers. Pretty sure it will work :)

from geo-three.

tentone avatar tentone commented on June 17, 2024

The demo is not broken it is working correctly. These errors are caused by missing tiles for ocean regions and can be ignored.

image

from geo-three.

xawill avatar xawill commented on June 17, 2024

Well, it doesn't work for me, over Switzerland, a very mountainous country in the Alps in Europe.

I am using Safari latest public version on macOS latest public version.

Capture d’écran 2021-06-15 à 10 11 39

from geo-three.

xawill avatar xawill commented on June 17, 2024

This is over Mont-Blanc (4809m):
Capture d’écran 2021-06-15 à 10 18 43

from geo-three.

tentone avatar tentone commented on June 17, 2024

Can you please provide a height "not shader" screenshot of these areas?

I have no way of testing with mac os, do you have any shader related error?

from geo-three.

xawill avatar xawill commented on June 17, 2024

No problem. I might be able to test on my side on Windows to try to narrow down what the issue is.

Here is the screenshot you requested: Mont-Blanc area again, with height "not shader". You can also see the output of the console, which is filled with hundred of such errors (one per tile, I would guess). I have no other error (no shader issue reported).

Capture d’écran 2021-06-15 à 14 23 36

PS: After writing this, I tested on Chrome on macOS and it works as expected (except from the gap at tiles edges, but I guess this is a complicated issue to solve, right ?):

Capture d’écran 2021-06-15 à 14 27 13

So apparently the issue is with Safari on macOS exclusively.

from geo-three.

tentone avatar tentone commented on June 17, 2024

Thanks a lot for this information this has to be fixed. The errors you're getting should not be related but i have to take a closer look maybe using a VM i can reproduce the error.

Thanks!

from geo-three.

xawill avatar xawill commented on June 17, 2024

Thanks a lot. I didn't have the chance to integrate your library in my project yet, but will in the following hours/days. I will then have more extensive access to the debugger and will let you know if I can better identify the issue.

I thought at first that the issue might be related to Safari not supporting webgl2, but I don't think you use it. And I had Safari webgl2 experimental feature enabled.

from geo-three.

JannikGM avatar JannikGM commented on June 17, 2024

I also have this issue on macOS running Firefox 89.0 (64-bit); so this isn't exclusive to Safari.

from geo-three.

tentone avatar tentone commented on June 17, 2024

Removed the need for OffscreenCanvas in new version. Should be working correctly in safari now!

Thanks a lot!

from geo-three.

laraduarte avatar laraduarte commented on June 17, 2024

Hi @tentone it's not working on my ipad, maybe we need to reopen this!
thank you

from geo-three.

tentone avatar tentone commented on June 17, 2024

Hello @laraduarte please open a new issue regarding this problem.

Include the version of the browser and OS that youre running and any content from the console please.

Thanks a lot!

from geo-three.

laraduarte avatar laraduarte commented on June 17, 2024

Hello @tentone

System: Ipad, iOS 15.6
Browser: Google Chrome
No errors in the console.

Thank you!

from geo-three.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.