GithubHelp home page GithubHelp logo

Comments (13)

tunnckoCore avatar tunnckoCore commented on May 18, 2024

What you mean with "in global packages"? I can't got it. ;]

from prompts.

FoRVaiS avatar FoRVaiS commented on May 18, 2024

Sorry, i was just about to update my post regarding that.

I've published the sample code in a private npm repository and installed globally: npm install -g local-prompts-global.

The package also has a bin command:

"bin": {
    "prompts-test": "index.js"
 }

Running prompts-test will result in a failing prompts application

from prompts.

tunnckoCore avatar tunnckoCore commented on May 18, 2024

Huh. And locally works? Is it working for the other type of prompts?

I have strong feeling, looking on the stack trace, that it may be because #19

from prompts.

tunnckoCore avatar tunnckoCore commented on May 18, 2024

Actually it isn't because of #19.

Possible fix would be

this.in.setRawMode = this.in.isTTY ? this.in.setRawMode : () => {}

So we won't think for it in other places.

from prompts.

FoRVaiS avatar FoRVaiS commented on May 18, 2024

Using Visual Studio Code (VSC) Terminal, set to Git Bash, I can use Prompts perfectly:
qug7ifv7sfqkb5-6g4stug

from prompts.

tunnckoCore avatar tunnckoCore commented on May 18, 2024

Can you try to replace this line

this.in.setRawMode(false);

with

      if (this.in.isTTY) {
        this.in.setRawMode(false);
      }

so we can verify more faster if it is only that thing. Because it not make sense to me since it works locally, but this bug is seen in other big projects too.

from prompts.

FoRVaiS avatar FoRVaiS commented on May 18, 2024

I no longer get the exception.
Prompts.text responds correctly and then duplicates its line.
Prompts.select remains un(scrollable)?
At the end, the application hangs, unable to kill the process via CTRL+Z and CTRL+C.

demo

EDIT: I've now realized that the 'duplicated' line is actually intentional. The previous line before it failed to update/disappear

from prompts.

tunnckoCore avatar tunnckoCore commented on May 18, 2024

Ah. Okey, thanks! We can continue work on #36 then.

CTRL+Z and CTRL+C.

It's another problem - #27

from prompts.

tunnckoCore avatar tunnckoCore commented on May 18, 2024

Sorry for bothering you, but.. What about adding else to the previous given if

      else {
        this.clear()
      }

Strongly believe that i would fix the problem with double lines, because this.clear is available after the this.render call, which in turn is called before the this.close() from the submit().

from prompts.

FoRVaiS avatar FoRVaiS commented on May 18, 2024

I've already shut my computer off, I'll definitely try this tomorrow.

from prompts.

tunnckoCore avatar tunnckoCore commented on May 18, 2024

Okey thanks anyway! 🐝 It's not comfortable in such situations when no tests and/or Windows specific things. Also, it's a bit tricky to test CLI prompts :D

from prompts.

terkelg avatar terkelg commented on May 18, 2024

Right, make sense to wrap the setRawMode in close in an if-statement too. So the issue is down to prompts.select not being scrollable on windows?

from prompts.

FoRVaiS avatar FoRVaiS commented on May 18, 2024

The only two functional issues I have come across so far is

  1. Unscrollable prompts.select
  2. Application hanging

Issue 2 might be related to a hanging stdin but my experience on I/O is extremely limited so I could be very wrong :X

from prompts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.