tfifie / 4steps Goto Github PK

SonarCloud, the cloud-based version of SonarQube, is available for free to open source projects. You connect your GitHub account and have your code scanned and analyed by SonarCloud for bugs, vulnerabilities and code smells.

You can find the instructions on how to do that here: https://about.sonarcloud.io/get-started/

After applying the fix in pull request #3, the compiler error when building the project with Clang/LLVM, as described in issue #1, was solved. With this fix, Clang can successfully compile the code and the resulting binary appears to run fine.

However, building the project with Clang/LLVM does result in a number of compiler warnings.

Perhaps you could look into these?

You can instruct qmake to create a Makefile for Clang/LLVM as follows:

qmake-qt5 4steps.pro -spec linux-clang

Thank you in advance.

Hi! Impressive work you've done on this project. 😃

I tried building your code with both G++ (GCC) and clang++ (Clang/LLVM). The former worked without problems. However, in the latter case, I would see errors complaining about the following:

Qt requires a C++11 compiler and yours does not seem to be that.

Steps to reproduce:

qmake-qt5 4steps.pro -spec linux-clang
make

However, after doing some Googling, I found out about the following workaround: after running "qmake-qt5 4steps.pro -spec linux-clang", open the created Makefile in an editor and the locate the following line:

CXX           = clang++

Now, append the compiler flag "-std=c++11" to it, so that it becomes like this:

CXX           = clang++ -std=c++11

Don't forget to save this change. Now, when you run make, the code will successfully compile with clang, albeit with a few warnings here and there. The resulting 4steps binary also seems to run fine and behave identically as when it were built with G++ (GCC).

To ensure maximum portability of your code, could you perhaps find some time to look into fixing the 4steps.pro file, so that it can generate proper Makefiles for both GCC and clang?

Thanks in advance.