tgavankar / kit Goto Github PK

If you toggle between quiet mode and regular mode when in scan mode, it always says "Entering scan mode" rather than the appropriate enter/exit.

Object construction time does not necessarily equate to the time the entry is added.

public InventoryEntry(UPCEntry upc) {
        this.upc = upc;
        this.created = Long.toString((new java.util.Date()).getTime() / 1000);
}

It's not thread safe currently.

We need unit tests to test DAO and Exporters.

STR:

1. Don't have a folder for export nor a file called inventorylist.csv in the export folder.
2. Try to export to file.
3. Get FileNotFoundException.

When a user custom entry is added via UPCDAO.addEntry, the foreign key for the upc_map.id entry is set to 0.

STR:

1. Scan an item that isn't in the local or cloud DB
2. Enter data for user-based custom entry
3. Check scanned_entries table (or try to export)

Expected: foreign key is properly linked

Actual: foreign key is listed as 0

Object construction time does not necessarily equate to the time the entry is added.

public InventoryEntry(UPCEntry upc) {
        this.upc = upc;
        this.created = Long.toString((new java.util.Date()).getTime() / 1000);
}

repro steps:

Welcome to Kitchen Inventory Tracker
Please note that you can enter 'h' or 'help' at the prompt to get a full list of commands
Enter command> e
Enter start date (MM-DD-YYYY)>05-18-1989
Enter end date or 'now' (MM-DD-YYYY))>05-18-2012
Enter end date or 'now' (MM-DD-YYYY))>05-18-2012
Enter end date or 'now' (MM-DD-YYYY))>05-18-2012
Enter end date or 'now' (MM-DD-YYYY))>now
Enter command>

self explanatory

Right now, when a SQLException occurs, we just throw it in some cases, catch and print stack traces in others, etc. There is no consistency.

Also, the test case addDuplicateEntry fails.

Need to add JavaDocs.

The setup/teardown that we have for DAO tests doesn't work as intended - a lot of the tests are failing with SQLException "column upc not unique", which means that it isn't being cleaned properly. We should switch to truncating the table or something.