the-balance-ffxiv / glam Goto Github PK

Since it's hardcoded and not functional, it's probably weird for a public launch:

Should have a number of settings:

• jobIcon
• jobName
• sideImage (for the image that shows up on larger screens)

The "inner content" can be markdown, since we could use a shortcode for a flex two-column layout.

Probably only on the mobile interface?

We'll definitely want to write something that generates (in the client or at build time) a table of contents for people to use to quickly navigate throughout the document.

I did get some feedback on suggestion (where my feedback was turning all h1/h2/etc into table of contents piece):

I mean, what if someone wants to use an h2 and not have it become a tab

So this is something that will likely need to be considered as part of this

I know this is sort of blocked waiting on branding, but we do need the issue for it.

Likely using something like hugo-lunr, perhaps?

Should be 3+ "tall" cards with an image focus and little text at the bottom (think title/subtitle).

Without a limit, things start looking a little... heavy:

Probably best to use hugo's first feature to configure, and use site parameters to configure that centrally.

This is only the menu templating

As of right now, we have to have a role field in /content/jobs/${role}/_index.md, but there's an issue:

• Setting it to role: tank:

With tank (singular), icon and branding is missing; with tanks (plural), icon/branding works but the "stripe" on the left side is missing.

It's not that I don't love you, it's that you don't work right now.

It takes a while each time to reinstall chrome headless and etc.

Just to make sure that standards are enforced

Should be a tabbed partial with all the roles – for now all 5 roles.

Might be useful to suggest some vscode plugins to make external dev easier to tolerate for theme dev. I found this one, but any other suggestions are probably good ones.

The header partial will likely contain everything in a header, including a menu partial

It's technically bad to launch without a copyright statement, but maybe we can slip it in as a param (and leave blank otherwise) so it's a smooth transition.

Per the front end team, this is something they'd like to see fixed before soft launch, if at all possible. Can review and change if needed after discussion.

(Ex for icons: SCH is massive compared to WHM in our demo video)

I did find some information here from a brief google search if someone wants to tackle that.

For any change that requires updating, please make sure to update the readme as well.

We need an initial implementation of Vue in Hugo. This should provide an example Table of Contents component to introduce developer patterns.

• Role landing page
  • Should either hard-code or have a drop-down for the role
  • Body text might be nice, but not required
• Job landing page
  • Should probably hardcode the title (or set a param and change templates) since icons are dependent upon it

We need this because it will be good to show content editors what their content will look like under this theme.

We need a workflow that, on PR creation, will build the exampleSite and take photos, uploading them as artifacts into the PR – this makes it easy to see if there are changes in the theme as time goes on.

Should be a quick in the data files:

For example, if Monk doesn't have an Advanced Guide, we want a template to handle this as opposed to the link just 404ing from the job landing page.

Might be worth tagging up with Nono in the issue comments depending on how he decides he wants to handle the contributing bit.

Since we're already using the job layout's list.html and single.html for paths like /jobs/$role/$job paths, the /job path looks just like a job landing page:

Per this suggested link, provide an ability to link directly to a piece of text (or a paragraph or something).

Was added quickly to fix for soft launch, but will need to be beautified to match Udra and Moth's mockups.

Whyyyyyyyyy?

Title.

This change will allow easier/cleaner changes to the colors and images on the page.

Title.

We need a landing page design that we can then dole out as other issues to implement partials/shortcodes/etc.

It's missing from the css! Oh the travesty!

Make sure this points to /balance-static/content/pages/credits.md

This change would allow for cleaner/easier manipulation of the images and color sets used on guide pages.

This component should be reusable for a "latest" and "recently updated" box. Should be 1/2 grid width on desktop and potentially tablet and full width on mobile

Fire up hugo locally on main and compare http://localhost:1313/ vs http://localhost:1313/jobs/healers/ vs http://localhost:1313/jobs/healers/scholar/ and notice that the header is missing.

Should have the following options (hopefully named parameters please):

• Code (the server invite code)
• Size (icon, medium, large)
• Color (optional, specifies background color – will default to a discord color if nothing selected)
• Image (optional, replaces the background with an image)

The pipeline is breaking in the screenshot part. Issue can be easily reproduced in any PR.

For example:

hosaka:jobs king$ find . -iname '*.svg' -type f
./healers/sage.svg
./healers/astrologian.svg
./healers/white_mage.svg
./healers/scholar.svg
./casters/black_mage.svg
./casters/red_mage.svg
./casters/summoner.svg
./healer.svg
./melee/samurai.svg
./melee/dragoon.svg
./melee/reaper.svg
./melee/ninja.svg
./melee/monk.svg
./ranged/dancer.svg
./ranged/machinist.svg
./ranged/bard.svg
./scholar.svg
./tanks/dark_knight.svg
./tanks/warrior.svg
./tanks/paladin.svg
./tanks/gunbreaker.svg

scholar.svg seems to be at the root which works for our scholar example pages, but not for any other jobs. I think we should put it under a directory, but that means changing the templates too.

Per Moth's post, this is the font that should be used on pages:

https://fonts.google.com/specimen/Kumbh+Sans?query=kumbh

Files can be grabbed within the XD link provided.

The cms config needs configuration for all four images on the page. This may lead to some changes in places like here, but the editor needs to allow these to be select-able and not locked to one image.

For example, see here:

Here's the frontmatter for that page in particular

---
title: DRG Leveling Guide
authors:
  - Balance DRG Staff
patch: "5.58"
lastmod: 2021-10-29T02:47:11.508Z
changelog:
  - date: 2021-10-29T02:48:36.195Z
    message: Created page
---

My operating theory is that something bad is broken in one of the following areas:

• setting some of the tab-specific css for the front-page role slider made it unusable in other areas
• the frontmatter's author section having a space in the name makes it very unhappy
• I don't know, please help me

As an example:

And also have a configurable space to dump pictures (like with the user profile editor)

The biggest one is attaching the screenshots to the PR instead of generating an artifact bundle

Should be pretty straightforward, and let us adjust if we have png vs svg, etc:

<h1>{{< jobIcon "war" size="large" extra_classes="pull-left" >}} Reaper</h1>

We'll need to discuss where we might want to put job icons and format etc.