Support Sync WebdriverCSS about chimpy

[samhatoum]

Comment by Sanjo
Tuesday Jan 26, 2016 at 14:07 GMT

---

The async wrapping should happen automatically for added webdriver commands.

So if it would work, this should be enough:

var result = browser.webdrivercss('body', {
  name: 'body',
  elem: 'body'
});

assert.ok(result.body.isWithinMisMatchTolerance);

Can you try this? If it doesn't work, I need to debug it.

[samhatoum]

Comment by nichite
Wednesday Jan 27, 2016 at 21:08 GMT

---

My testing shows that this way does not work either--thinking back, that's why I tried to wrap it myself in the first place. It's giving me the same error, Can't wait without a fiber.

I'm using [email protected] and [email protected]. Other versions of webdrivercss aren't compatible with webdriverio v 3.0+. Could that be causing compatibility issues?

[samhatoum]

Comment by Sanjo
Wednesday Jan 27, 2016 at 21:17 GMT

---

You pass the client/browser instance from Chimp to webdrivercss, right?

[samhatoum]

Comment by nichite
Wednesday Jan 27, 2016 at 21:38 GMT

---

Correct, earlier in my code I have:

var webdrivercss = require('webdrivercss');
[...] // Other stuff
webdrivercss.init(browser, {
          screenshotRoot: 'screenshots',
          failedComparisonRoot: 'diffs',
          misMatchTolerance: 0.05,
          screenWidth: [320,480,640,1024]
        });

as per the example on webdriver's npm page.

[samhatoum]

Comment by Sanjo
Wednesday Jan 27, 2016 at 22:50 GMT

---

Ok. So probably some asynchronous code in webdrivercss that is not wrapped automatically with wrapAsync causes the callback to not be in the fiber. To fix that we need to create a sync-webdrivercss package that patches the webdrivercss package, to work with fibers. Like we did with webdriver already (https://github.com/xolvio/sync-webdriverio). Or a fork of webdrivercss, if the patching is too hard.