Comments (5)
Comment by Sanjo
Tuesday Jan 26, 2016 at 14:07 GMT
The async wrapping should happen automatically for added webdriver commands.
So if it would work, this should be enough:
var result = browser.webdrivercss('body', {
name: 'body',
elem: 'body'
});
assert.ok(result.body.isWithinMisMatchTolerance);
Can you try this? If it doesn't work, I need to debug it.
from chimpy.
Comment by nichite
Wednesday Jan 27, 2016 at 21:08 GMT
My testing shows that this way does not work either--thinking back, that's why I tried to wrap it myself in the first place. It's giving me the same error, Can't wait without a fiber
.
I'm using [email protected]
and [email protected]
. Other versions of webdrivercss aren't compatible with webdriverio v 3.0+. Could that be causing compatibility issues?
from chimpy.
Comment by Sanjo
Wednesday Jan 27, 2016 at 21:17 GMT
You pass the client/browser instance from Chimp to webdrivercss, right?
from chimpy.
Comment by nichite
Wednesday Jan 27, 2016 at 21:38 GMT
Correct, earlier in my code I have:
var webdrivercss = require('webdrivercss');
[...] // Other stuff
webdrivercss.init(browser, {
screenshotRoot: 'screenshots',
failedComparisonRoot: 'diffs',
misMatchTolerance: 0.05,
screenWidth: [320,480,640,1024]
});
as per the example on webdriver's npm page.
from chimpy.
Comment by Sanjo
Wednesday Jan 27, 2016 at 22:50 GMT
Ok. So probably some asynchronous code in webdrivercss that is not wrapped automatically with wrapAsync causes the callback to not be in the fiber. To fix that we need to create a sync-webdrivercss package that patches the webdrivercss package, to work with fibers. Like we did with webdriver already (https://github.com/xolvio/sync-webdriverio). Or a fork of webdrivercss, if the patching is too hard.
from chimpy.
Related Issues (20)
- Node 10.1.0, Chimp and fibers problem (can we upgrade fibers?) HOT 33
- Hooks errors fix for #687 HOT 5
- Security vulnerability HOT 5
- Chrome render issue with chimp
- Make chimp work with JDK10 HOT 6
- Difference between this repo(Chimpy) and Chimp HOT 4
- wrapAsync is not defined HOT 2
- Problems running chimpy on Gitlab `Error: unknown error: Chrome failed to start: exited abnormally` HOT 6
- Chimpy doesn't appear to support Sauce Connect (which is required for testing non-public apps via Sauce Labs)
- Output still references to chimp and outdated website.
- Support latest version of Chrome! HOT 6
- I can't run the unit tests for Chimpy HOT 4
- Using import syntax in config file throws error
- Chimpy crashes upon app server restart with --ddp flag HOT 2
- chromedriver 2.46.0 download URL invalid
- Adding chimpy as dev-dependency breaks app HOT 2
- node 12: bump fibers dependency HOT 13
- cannot install dev-dependencies -> jest-cli dependency is invalid
- Lots of warnings on deprecation of packages with Node 11.10.x itself HOT 2
- Project Abandoned, future of this project? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chimpy.