Comments (12)
Comment by samhatoum
Tuesday May 31, 2016 at 20:52 GMT
I guess the 3rd option would be to host our fork of cucumber-js on your private npm repository, as well as a modified version of Chimp that points to your_npm/cucumber-js
I don't think option 1 is possible due to us using fibers and this is not the design of cucumber-js.
Option 2 is possible, we would just need to publish xolvio-cucumber
or similar.
@lgandecki / @sanjo what are your thoughts?
from chimpy.
Comment by dilipkumar2k6
Wednesday Jun 01, 2016 at 16:37 GMT
Thanks @samhatoum, 3rd option could be ok for short term however will create problem in future to keep updating our git repository.
Please see if option 2 is possible. I can assist if anything i can do for option 2.
from chimpy.
Comment by lgandecki
Thursday Jun 02, 2016 at 12:11 GMT
I like the idea of having the fork on the npm the most. If I'm not missing anything it shouldn't add too much effort to publish new version on each update.
from chimpy.
Comment by dilipkumar2k6
Thursday Jun 02, 2016 at 17:19 GMT
I understand, but having forked version of cucumber-js in local npm repository and updating package.json to use the local cucumber-js is tedious work.
I am thinking if we can go with option 2 to publish xolvio-cucumber as a separate module. This will make chimp.js installation on local npm repo very easy.
from chimpy.
Comment by lgandecki
Thursday Jun 02, 2016 at 18:05 GMT
Sorry, yeah, I meant to express my support for option 2!
from chimpy.
Comment by dilipkumar2k6
Thursday Jun 02, 2016 at 21:27 GMT
Great, seems this will help everyone in future. I am ready to help to move with option 2.
from chimpy.
Comment by Sanjo
Thursday Jun 02, 2016 at 22:47 GMT
Yup, option 2 will work.
from chimpy.
Comment by samhatoum
Thursday Jun 02, 2016 at 22:49 GMT
alright, #2 it is. coming in the next release
from chimpy.
Comment by dilipkumar2k6
Friday Jun 03, 2016 at 01:31 GMT
Thanks guys. You all are awesome!!!
from chimpy.
Comment by dilipkumar2k6
Friday Jun 03, 2016 at 23:59 GMT
@samhatoum, one of my team mate was exploring package.json options and came across bundledDependencies. Seems like you can update package.json to move "cucumber-js" into bundledDependencies, it will take care of embedding the dependency on publishing. Following is stackoverflow link for your reference.
Please have a look and see if this is easier option for you.
from chimpy.
Comment by dilipkumar2k6
Tuesday Jul 19, 2016 at 21:18 GMT
Hi @samhatoum,
I still see cucumber is referring as relative path to github.com.
"cucumber": "xolvio/cucumber-js#v1.0.0-chimp"
It will be great if your team can help on this. Our team is not able to use it because of this problem.
Thanks,
Dilip
from chimpy.
Comment by jezstephens
Monday Aug 22, 2016 at 16:48 GMT
Does anyone know how WebdriverIO's wdio
test runner handles this using an unmodified cucumber-js? It uses fibers as well, I believe (via wdio-sync).
from chimpy.
Related Issues (20)
- Node 10.1.0, Chimp and fibers problem (can we upgrade fibers?) HOT 33
- Hooks errors fix for #687 HOT 5
- Security vulnerability HOT 5
- Chrome render issue with chimp
- Make chimp work with JDK10 HOT 6
- Difference between this repo(Chimpy) and Chimp HOT 4
- wrapAsync is not defined HOT 2
- Problems running chimpy on Gitlab `Error: unknown error: Chrome failed to start: exited abnormally` HOT 6
- Chimpy doesn't appear to support Sauce Connect (which is required for testing non-public apps via Sauce Labs)
- Output still references to chimp and outdated website.
- Support latest version of Chrome! HOT 6
- I can't run the unit tests for Chimpy HOT 4
- Using import syntax in config file throws error
- Chimpy crashes upon app server restart with --ddp flag HOT 2
- chromedriver 2.46.0 download URL invalid
- Adding chimpy as dev-dependency breaks app HOT 2
- node 12: bump fibers dependency HOT 13
- cannot install dev-dependencies -> jest-cli dependency is invalid
- Lots of warnings on deprecation of packages with Node 11.10.x itself HOT 2
- Project Abandoned, future of this project? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chimpy.