GithubHelp home page GithubHelp logo

jest-runner-standard's People

Contributors

just-paja avatar lgandecki avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar

Forkers

maxpolun just-paja

jest-runner-standard's Issues

Fails to find standard.js with lerna

Hi, thanks for this runner, I've been using it for quite some time now. I've come to a troublesome interaction with lerna and react-scripts configuration.

In lerna, the file structure should look like this:

lerna-root/
├ node_modules/
├ packages/
│ └ project-root/
│   ├ (project files)
│   └ (no node modules)

Unfortunately, react-scripts define webpack loaders to cache stuff under project's node_modules. Like this:

lerna-root/
├ node_modules/
├ packages/
│ └ project-root/
│    ├ node_modules/
│    │  └ .cache/
│    │      ├ babel-loader/
│    │      └ eslint-loader/
│    └ (project files)

Well, jest-runner-standard is configured to find the closest node_modules and use them as a source to find standard, ignoring the lerna-root node_modules. The result is:

Test suite failed to run

    Cannot find module '.../packages/improv-match-referee/node_modules/standard'
    Require stack:
    - .../node_modules/jest-runner-standard/helpers/getLocalStandard.js
    - .../node_modules/jest-runner-standard/run.js
    - .../node_modules/jest-worker/build/workers/processChild.js

      at exports.getLocalStandard (../../node_modules/jest-runner-standard/helpers/getLocalStandard.js:6:10)
      at Function.module.exports (../../node_modules/jest-runner-standard/run.js:11:20)

I propose that the getLocalStandard gets extended so it looks for standard in project root ancestor directories as well.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.