thebusybiscuit / souljars

A Repository for my Slimefun Addon "SoulJars"

Hello 👋, I'm TheBusyBiscuit!

🍪 About me

Student at University, coffee enthusiast and Open-Source software developer.
I am currently maintaining @Slimefun and @MockBukkit.

---

🏆 Meaningless but shiny

---

📚 Tools and languages

               

               

               

---

🎨 Image credit

Profile picture, Slimefun logo and dough logo drawn by @IAmSorry_Art <3.

souljars's Issues

[Suggestion] StackMob integration?

Is it possible to integrate stackmob plugin into soulJars addon?

Ancient Altar won't turn a broken spawner into a Reinforced spawner

Description (Required)

As I was placing the recipe to take a broken spawner into a reinforced spawner, i put the correct recipe in the auto ancient altar, and it would not craft it. No error message was given. So I then tried the regular ancient altar, did the same thing and got a message saying to use the correct recipe. I have video proof attached that I did use the proper recipe.

Steps to reproduce the Issue (Required)

https://youtu.be/UxCPO_wPhAI

Expected behavior (Required)

I expected the altar to make the reinforced spawner as the recipe showed.

Server Log / Error Report

latest.log

Environment (Required)

• Minecraft Version: 1.16.3
• CS-CoreLib Version:
• Slimefun Version:
• SoulJars Version:
  

spanwer bug

Description (Required)

Can't, repair the spawners

Steps to reproduce the Issue (Required)

https://www.youtube.com/watch?v=1jTJuedGTwg&feature=youtu.be

Expected behavior (Required)

the spawner is working but when it was removed with a beak to remove spanwer it turned into a pig and then I tried to repair it but it wouldn't let me

Server Log / Error Report
Nothing

Environment (Required)

https://imgur.com/vTt98zb

Unable to reinforce the Soul jars broken spawner with the altar

Attempted to create a skeleton spawner and ran into and unknown recipe problem with the reinforce spawner step. Doing some testing in creative by spawning in a spawner with,

/setblock ~ ~-1 ~ spawner{SpawnCount:1,MaxNearbyEntities:6,SpawnRange:4,Delay:20,MinSpawnDelay:60,MaxSpawnDelay:120,RequiredPlayerRange:6,SpawnData:{id:"minecraft:skeleton"}}

breaking it with the pickaxe of containment works with the ritual, but the one from soul jars does not. The only difference I could tell between the 2 broken spawners in my inventory was on the PublicBukkitValue line in the NBT tags. the one that works with the ritual only says "BROKEN_SPAWNER", whereas the other one says "SKELETON_BROKEN_SPAWNER". Upon removing the skeleton part from this tag both spawners stacked together in my inventory and both worked on the ritual.

CraftBukkit v1_14_R1
CS-CoreLib v1.6.2
Slimefun vDEV - 400 (git be0035f2)
Installed Addons (7)
Barrels vDEV - 8 (git 447cb487)
SlimefunOreChunks vDEV - 3 (git 7ddf966e)
SlimeXpansion vDEV - 4 (git 5bf10c29)
SoulJars vDEV - 10 (git 58202ab)
ExtraGear vDEV - 3 (git de222ab7)
ExoticGarden vDEV - 24 (git 4a0e0c0e)
ChestTerminal vDEV - 20 (git a698c614)

these are the versions currently running on the server.

SoulJars Mob error list

Description (Required)

when launching the server it shows this error nothing much to explain :c

Steps to reproduce the Issue (Required)

Just launching the server and it showed this

Expected behavior (Required)

to work

Server Log / Error Report

https://paste.denizenscript.com/View/103889

Environment (Required)

• Minecraft Version: 1.19.3
• Slimefun Version: Dev 1035
• SoulJars Version: Dev 23

SoulJar Soul Amount Resetting

Description (Required)

Killing an animal and placing the Soul Jar on the ground completely resets the amount of mobs in a Soul Jar.

Steps to reproduce the Issue (Required)

https://youtu.be/PBLWyUbVf4c

Expected behavior (Required)

Not reset the amount of Souls, or prevent placing.

Server Log / Error Report

No errors

Environment (Required)

SoulJar don't work as it should

• When you kill a mob, the Sjar don't colect the soul. Its just a head with the skin of the jar.

-- when you kill a mob, the jar separates from the group and becomes a jar with that mob's soul

action

Versions

Soul Jars does not craft (or /sf give) the correct spawner

Description (Required)

The broken spawners crafted from soul jars are not modified properly.

This is what is given:

This is what it should be:

The broken spawner can also be placed, but will always default to pig. Once broken, the spawner is still a soul jars broken spawner. These spawners also can't be repaired via the ancient altar.

Here's the meta:

Steps to reproduce the Issue (Required)

Run /sf give <user> CAVE_SPIDER_BROKEN_SPAWNER (Any spawner type works)

Expected behavior (Required)

These spawners should be proper broken spawners.

Server Log / Error Report

N/A

Environment (Required)

Jars always empty regardless of kills

Certainly a version issue, can't say which build it started at. Player said they were getting to 128 and the jar would immediately empty afterwards... I attempted to collect any souls into a jar and could not so couldn't test the reported bug.
Currently we are running these versions... I am certain the issue will persist into 1.15, however.
[20:54:47 INFO]: Paper v1_14_R1 (237)
[20:54:47 INFO]:
[20:54:47 INFO]: CS-CoreLib vDEV - 79 (git ec5b4c24)
[20:54:47 INFO]: Slimefun vDEV - 369 (git 33adb7e7)
[20:54:47 INFO]:
[20:54:47 INFO]: Installed Addons (12)
[20:54:47 INFO]: Barrels vDEV - 7 (git 0d14dd9f)
[20:54:47 INFO]: SlimeXpansion vDEV - 4 (git 5bf10c29)
[20:54:47 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[20:54:47 INFO]: ChestTerminal vDEV - 19 (git ebf13b83)
[20:54:47 INFO]: HotbarPets vDEV - 20 (git cd87bc60)
[20:54:47 INFO]: ExoticGarden vDEV - 22 (git a855f5b7)
[20:54:47 INFO]: SoulJars vDEV - 4 (git 4a600aa)
[20:54:47 INFO]: SlimefunOreChunks vDEV - 3 (git 7ddf966e)
[20:54:47 INFO]: ElectricSpawners vDEV - 5 (git c3f8cc9d)
[20:54:47 INFO]: ExtraHeads v1.1
[20:54:47 INFO]: PrivateStorage vDEV - 6 (git b012877e)
[20:54:47 INFO]: DyedBackpacks vDEV - 1 (git 4b4d1f0f)

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update actions/checkout action to v3.6.0
• Update actions/setup-java action to v3.13.0
• Update dependency org.apache.maven.plugins:maven-shade-plugin to v3.6.0
• Update actions/checkout action to v4
• Update actions/setup-java action to v4
• Update dependency org.bstats:bstats-bukkit to v3
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

github-actions

.github/workflows/maven.yml

• actions/checkout v3.5.3
• actions/setup-java v3.11.0

maven

pom.xml

• org.apache.maven.plugins:maven-shade-plugin 3.2.4
• org.spigotmc:spigot-api 1.16.5-R0.1-SNAPSHOT
• com.github.TheBusyBiscuit:Slimefun4 RC-27
• org.bstats:bstats-bukkit 2.2.1

---

• Check this box to trigger a request for Renovate to run again on this repository

ZOMBIFIED_PIGLIN - invalid mob

Description (Required)

It says that ZOMBIFIED_PIGLIN is invalid mob
([SoulJars] IllegalArgumentException: Possibly invalid mob type: ZOMBIFIED_PIGLIN)
full config https://pastebin.com/CkcKYxR3

Steps to reproduce the Issue (Required)

Start the server with ZOMBIFIED_PIGLIN in the config

Expected behavior (Required)

ZOMBIFIED_PIGLIN will be valid mob

Server Log / Error Report

Only this: [Server thread/ERROR]: [SoulJars] IllegalArgumentException: Possibly invalid mob type: ZOMBIFIED_PIGLIN

Environment (Required)

Can't, repair the spawners

Description (Required)

Can't, repair the spawners

Steps to reproduce the Issue (Required)

https://www.youtube.com/watch?v=1jTJuedGTwg&feature=youtu.be

Expected behavior (Required)

the spawner is working but when it was removed with a beak to remove spanwer it turned into a pig and then I tried to repair it but it wouldn't let me

Server Log / Error Report

Nothing

Environment (Required)

https://imgur.com/vTt98zb

Soul Jars Build 13 not capturing souls

A common issue I have experience (and have seen appearing in the discord server) is that soul jars are no longer capturing souls since the latest SF Build + Soul Jars. The Jar stays in the player's inventory in the unbound state, but previously filled jars can be crafted into broken spawners and new Soul Jars can be crafted as well.

Obsolete mob type, throws an exception during server startup.

The plugin should load with no problems. It's compatible and is enabled when I start the server.

However, when I start the server I get:
[17:14:33 INFO]: [SoulJars] Enabling SoulJars vDEV - 22 (git aded79dd) [17:14:33 ERROR]: [SoulJars] IllegalArgumentException: Possibly invalid mob type: PIG_ZOMBIE
I think you should change PIG_ZOMBIE to ZOMBIFIED_PIGLIN. I've done a little diggin in the internet and found this
You say that you've already fixed that but I'm using a newer version, the latest in fact, and the issue is still there.

Just for context, I'm running PaperMC for Minecraft 1.16.5.

• Minecraft Version: 1.16.5
• Slimefun Version: RC 26
• SoulJars Version: DEV 22

Small bug

small bug
[SoulJars] IllegalArgumentException: Possibly invalid mob type: PIG_ZOMBIE

• Minecraft Version: 1.19.3
• Slimefun Version: 1050
• SoulJars Version: 23

Reinforced spawner craft with only 1 soul in the souls jar

Description (Required)

The craft of the reinforced spawner does not look at the number of mobs inside the souls jars. They can be crafted with only 1 mob in the souls jar instead of 128.

Steps to reproduce the Issue (Required)

Try to craft a reinforced spawner with only 1 soul Inside the souls jar.

Expected behavior (Required)

To only be able to craft the reinforced spawner with a maxed out souls jar.

Server Log / Error Report

No error

Environment (Required)

Soul jars loop back to 1 soul after exceeding 128

Description (Required)

The souls jar once arrived at 128 goes back to 1

Steps to reproduce the Issue (Required)

Continue to fill the souls jar until it loop back to 1.

Expected behavior (Required)

The souls jar should cap to the max number of souls.

Server Log / Error Report

No error

Environment (Required)