thedhanawada / livevalidatejs Goto Github PK

The purpose of this enhancement is to ensure consistency in the way the library handles and displays error messages. In the current implementation, we defined a function named handleErrorMessage which creates an error message and appends it to the designated error element. However, not all parts of the code are utilizing this function to display error messages, leading to inconsistency and potential code duplication.

Where Changes Could Be Made

There are two primary places where changes can be made: the addGroupValidation and validateAsync functions.

Here is a part of the addGroupValidation function:

if (isValid) {
  groupErrorElement.innerHTML = '';
} else {
  groupErrorElement.innerHTML = errorMessage;
}

And here is a part of the validateAsync function:

validationFunction(input.value.trim(), (errorMessage) => {
  if (errorMessage) {
    reject(errorMessage);
  } else {
    resolve();
  }
});

In both these code snippets, we're directly assigning the errorMessage to the innerHTML of the respective error elements.

Direction of Solution

Instead of directly manipulating the innerHTML, you can utilize the handleErrorMessage function. This function is designed to create a new error message, properly formatted and appended to the given error element.

The challenge here is to replace the direct innerHTML assignments in both functions with appropriate calls to handleErrorMessage. You'll need to consider the arguments that handleErrorMessage requires (an error element and an error message), and ensure these are correctly provided from both addGroupValidation and validateAsync functions.

By doing this, you'll be ensuring that all error messages across the library are handled consistently and displayed in a uniform manner, making your code more maintainable and user-friendly. Remember to thoroughly test the after making these changes to ensure everything still works as expected.