theemo-tokens / theemo Goto Github PK

Make the parser public, it is lacking an export.

As part of #689 I deactivated a couple of tests, since the test-setup with fixtures had cyclic dependencies.

This needs to be reworked as part of this ticket and make tests available again through vitest.

Somewhen during development - I thought - it was possible to run vitest wo/ having the code build before. As part of this ticket, investigate, if bringing back vite to each ticket (with its config), it can run tests wo/ them being built by tsup.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Other Branches

These updates are pending. To force PRs open, click the checkbox below.

• Replace dependency read-pkg-up with read-package-up ^11.0.0

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency @types/node to v20.11.24
• Update dependency prettier to v3.2.5
• Update typescript-eslint monorepo to v7 (major) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Add this feature as a plugin, which uses the existing functions to extract variables into tokens.

Put this behind a configuration option.

Having this configuration in Figma:

with:

should create a CSS Custom property as:

--navigation-links-base: var(--intent-action-base-text);

It is also properly extracted into a token json file, but the way style dictionary resolves these references and then turns them into CSS needs some help.

See:

• https://tr.designtokens.org/format/#composite-design-token
• https://tr.designtokens.org/format/#composite-types

Currently when syncing tokens, there is a one-to-one mapping of "node" to token. However for composite tokens this is a one-to-many relationship.

The code is sort well structured within src/. That should be split apart into multiple packages, so that there is:

• theemo, maybe @theemo/cli (actually only a shim)
• @theemo/core - shared and common parts
• @theemo/sync - sync from figma to style dictionary
• @theemo/build - build a theemo theme
• @theemo/theme - theme types and APIs
• @theemo/figma - connection to figma
• @theemo/style-dictionary - connection to style dictionary

to better reason about the code and keep things isolated.

Hi! It looks like export to jsonbin.io stopped working.

I'm following the steps described on the support page:

1. Enter credentials in settings
   a. Create an account and copy the API Key - ✅
   b. Create a bin and copy the bin URL - it is impossible to create an empty bin

I put API key and bin URL on the settings page in plugin and hit save:

2. On the tools tab the Export Settings button becomes available. Clicking the button will export your references. - following the instruction:

Next, I check if the bin was updated with data from the plugin:

Looks like the bin didn't get updates🤷‍♂️

Can you please help me with it?

Hi! It looks like export to jsonbin.io stopped working.

I'm following the steps described on the support page:

1. Enter credentials in settings
   a. Create an account and copy the API Key - ✅
   b. Create a bin and copy the bin URL - it is impossible to create an empty bin

I put API key and bin URL on the settings page in plugin and hit save:

2. On the tools tab the Export Settings button becomes available. Clicking the button will export your references. - following the instruction:

Next, I check if the bin was updated with data from the plugin:

Looks like the bin didn't get updates🤷‍♂️

Can you please help me with it?

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Cannot find preset's package (github>whitesource/merge-confidence:beta)

Any plan to add the ability to reference text styles? Would be a great feature!

It seems like I can access values with getValue() within another function inside of reader. I want to ensure that the value is included in the output, as expected in the output for this step, right?

import { getValue, getTypefromStyle } from 'theemo/dist/tools/figma/token.js';


      getTypeFromToken: (token) => {
        if (token.style) {
          console.log(getValue(token, {})); // ok can get colors
          return getTypefromStyle(token.style);
        }

        return '';
      },

Hi, I'm not sure I fully understand theemo. But I have nodes. And I would expect to have values too. However, I don't see how values are extracted.

I've looked in https://theemo.io/cli/sync/reader

https://theemo.io/cli/sync/reader#output

export default {
  sync: {
    reader: {
      tool: 'figma',
      figmaFile: FIGMA_FILE_ID,
      figmaSecret: FIGMA_SECRET,

      // referencer
      referencer: {
        type: 'figma-plugin',
        plugin: 'theemo',
        pluginConfig: {
          jsonbinFile: JSONBIN_FILE_ID,
          jsonbinSecret: JSONBIN_SECRET,
          formats: {
            color: 'hex',
            colorAlpha: 'rgb',
          },
        },
      },
      getValueFromText(node) {
        console.log(node); // I'd expect to see something here as well https://theemo.io/cli/sync/reader#getvaluefromtext
        return node;
      },
      getPropertiesForToken: (token, document) => {
        console.log(document);
        if (token.figmaName) {
          return {
            figmaName: token.figmaName,
          };
        }
      },
    },
    writer: {
      tool: 'style-dictionary',
    },
  },
};

output

'143:1637': {
      key: 'd54ed81ff7b55f52427f0ce4194cad53031faf23',
      name: '.reference/accent/purple/20',
      styleType: 'FILL',
      remote: false,
      description: ''
    },
    '143:1638': {
      key: 'e5ee131b9336f5e805dec61889a31ec2f39a6029',
      name: '.reference/accent/purple/30',
      styleType: 'FILL',
      remote: false,
      description: ''
    },
    '143:1639': {
      key: '88fbb355e39c54dca51519ffc371d816a90a4943',
      name: '.reference/accent/purple/40',
      styleType: 'FILL',
      remote: false,
      description: ''
    },
    '143:1640': {
      key: '4739abc0e5fb6f254c3e4b3c384ff120cf79aec7',
      name: '.reference/accent/purple/50',
      styleType: 'FILL',
      remote: false,
      description: ''
    },
    '143:1641': {
      key: 'c542f4a9003f767de0375d7776abecdbb693b6c7',
      name: '.reference/accent/purple/60',
      styleType: 'FILL',
      remote: false,
      description: ''
    },
    '143:1642': {
      key: '1293f4f69be54cfcfa1d205d4490db13a189da8e',
      name: '.reference/accent/purple/70',
      styleType: 'FILL',
      remote: false,
      description: ''
    },
    '143:1643': {
      key: 'da2076041b7b1d9b8d41810efcd70abdc9870217',
      name: '.reference/accent/purple/80',
      styleType: 'FILL',
      remote: false,
      description: ''
    },
    '143:1644': {
      key: '773574811326f26b0ed14cf3da5b049cfc5abf61',
      name: '.reference/accent/purple/90',
      styleType: 'FILL',
      remote: false,
      description: ''
    },
    '147:1655': {
      key: '231a00f883677e5fc05483445b0926b2b89c7202',
      name: 'semantic/content/validation/success',
      styleType: 'FILL',
      remote: false,
      description: ''
    },
    '147:1666': {
      key: 'f9330b6a9cb2ee7579ff4a4e0ee89e43cddea390',
      name: 'semantic/content/validation/failure',
      styleType: 'FILL',
      remote: false,
      description: ''
    },
    '147:1728': {
      key: 'f5fc1c55e4c9eaa84a6bd35eddff701f1519030d',
      name: 'semantic/alert-label/critical',
      styleType: 'FILL',
      remote: false,
      description: ''
    },
    '147:1729': {
      key: 'f8ac6ba651a516ecf5438021e10e4340340b03bd',
      name: 'semantic/alert-label/high',
      styleType: 'FILL',
      remote: false,
      description: ''
    },
    '147:1730': {
      key: 'fc4d48659a5baae97c3deff26673d0e537b36de1',
      name: 'semantic/alert-label/medium',
      styleType: 'FILL',
      remote: false,
      description: ''
    },

I'm using the Figma plugin to reference color styles and I've got two published libraries: "Styles - Light" and "Styles - Dark". I switch between color modes using the "Swap Library" feature and almost everything works flawlessly.

I've been exporting and converting tokens with a 100% custom script, and I recently wanted to go deep with Theemo's CLI, but I can't figure out how to link those files (and their respective JSON bins) into theemo.js though. Is it actually possible?

sync: { reader: { tool: 'figma', figmaFile: FIGMA_FILE, figmaSecret: FIGMA_SECRET, referencer: { type: 'figma-plugin', plugin: 'theemo', pluginConfig: { jsonbinFile: JSONBIN_FILE, jsonbinSecret: JSONBIN_SECRET, formats: { color: 'hex', colorAlpha: 'rgb' } } },

Make all types public, that are used in the config, e.g. FigmaToken - some are private.

In this line:

if a value is 0, the expression evaluates to false. It must be checked against undefined.

In @theemo/figma make it understand Variables as exported from theemo-tokens/figma-theemo#56

... and export them as tokens.

For @theemo/figma:

• Variables module:
  • Parses tokens from objects of Variable
• Uses module to read the /variables endpoint (when using enterprise plan)
• Define hooks for the config to parse and understand variables

For @theemo/figma -> theemo plugin:

• Define Plugin API for @theemo/figma
• theemo plugin
  • Uses variable module to handle variables exposed from theemo figma plugin
  • Read references from theemo as of .theemo/config -> styles
  • Read transforms from theemo as of .theemo/config -> variables

For @theemo/style-dictionary:

• Handle transforms in @theemo/style-dictionary

When using Import under Tools, I can't seem to be able to import references.

Here's the error from the Figma Console

• Automatic changelog generation
• Release scripts
  • Workspace management