theforumhelpers / theforumhelpers.github.io Goto Github PK

Describe the bug
54329 is the first curator listed, but he isn't the first curator in the studio.

To Reproduce
Go to the list of Forum Helpers, scroll down to curators.

Expected behavior
They should be closer to the bottom

Browser Information
My browser / operating system: ChromeOS 12739.94.0, Chrome 80.0.3987.137, No Flash version detected

Additional context
None

We should try to find better fonts for text in different parts of the website. I suggest trying Arial or Arimo. Of course, we can look for other things too. This is just so that we can have a more readable font and make the site look better.

Be Moist (currently in the footer) is not as common as it is right now, so I think it could replaced with another recent trend such as 'Be whirled' (whirl cat).

Edit: I will likely make the pull request myself.

The logo for the Forum Helpers is a rectangle, but favicons (the little picture which is displayed in the tab) needs to be a square. Would anyone be interested in making a square version of the Forum Helpers logo?

margins on small devices make reading content impossible

Describe the bug
The labeler works but it does not label things unreviewed.

To Reproduce
make a pr and see that it does not mark things as unreviewed.

Expected behavior
it should mark things as unreviewed

Browser Information
n/a

Additional context
none

Currently, this site uses cnd2 to get a user's profile picture. Recently, the 'image hosting' Scratch uses, was changed from cnd2.scratch.mit.edu to uploads.scratch.mit.edu. In the list of forum helpers, it gets the user's profile picture through cnd2. It still works, but it should be updated to a uploads.scratch.mit.edu image link in case Scratch gets rid of all images hosted on cnd2.

The new format for profile picture images using uploads is https://uploads.scratch.mit.edu/users/avatars/USERID.png

Right now, the list of Forum Helpers page is very empty, as not many users have provided biographies. I'm wondering if there would be any way to encourage more users to provide biographies. Here are a few of my ideas:

1. Leave comments on the profiles of users without bios.
   -We could leave a comment which would say something like this: "Hi there! We are in the process of creating a Forum Helpers website, and one of the pages has a list of Forum Helpers and biographies. Would you be able to provide a biography which we would be able to use on that page?"

2. Use bios from the bio project
   -This would be helpful for allowing us to get biographies from users without asking them for one, but there are some downsides, like the biographies might not be up to date, and newer users won't have biographies in that project.

Does anyone have any other ideas and/or thoughts on these ones?

issues relating to C:\ drives will begone because of localhost

Describe the bug
awesome-llama's pfp and bio are under Sigton's name, and awesome-llama's spot is missing.

To Reproduce
Scroll down to Sigton on the Forum Helpers page

Expected behavior
awesome-llama and Sigton should be separate

Browser Information
N/A (Applies to everyone)

Additional context
None

(removed)

The front page needs to be updated (for like the 4th time) to reflect the new application process where managers have the ability to object.

I will do this after #81 is merged to avoid merging conflicts.

Describe the bug
When a user does not provide a biography, their bio is set to "No Biography Provided.". However, some bios are missing a period after provided.

To Reproduce
Look at the list of forum helpers page.

Expected behavior
There should be a period after provided.

Browser Information
Not applicable.

Additional context
None

Currently this software is proprietary (all rights reserved) to whoever wrote the initial copy and thus is (by technicality) illegal for anyone to copy / develop upon it themselves. I'd recommend the MIT license to go alongside the ethics of Scratch and MIT.

Hello. I somehow got the domain https://theforumhelpers.glitch.me, the domain https://the-forum-helpers.glitch.me, and also the domain https://tfh.glitch.me.

And i am requesting permission to create a website on behalf of The Forum Helpers.
The website i am trying to make is basically a Scratch Statistics visualizer, using data from https://scratchdb.lefty.one/ to get your scratch statistics and display them for you.

What do you guys think?

Title.

cc @Accio1

I've noticed that they don't really blend in, and I think the underline looks quite ugly.

Just a small suggestion.

Perhaps the colour of links should be the same as the background, and on hover (add transitions so it looks way better) make it the same as the top navigation bar. and as i said remove the outlines if it looks ugly.

The CSS:
a {
text-decoration: none;
color: i think it was powderblue;

transition-property: color;
transition-timing-function: ease;
transition-delay: 0s;
transition-duration: 1s;
}
a:hover {
color: color of topnav
}

The code hasnt been tested, so yeah.

Describe the bug
The auto labeler worked in the test but the last 3 pull requests I made were not auto-labeled.

To Reproduce
Make a Pull Request
See that it does not get auto labeled upon opening it, even if the checks pass.

Expected behavior
The pull request should be auto-labeled.

Browser Information
Mac OS Big Sur 11.1, Chrome 88.

Additional context
If the pull request is closed and later reopened, I think the labeler might run.

Describe the bug
The links in the footer are right on top of each other, making them hard to read.

To Reproduce
Scroll down to the footer

Expected behavior
The links should be easy to read.

Browser Information
n/a

Additional context
This can be fixed by styling the
element to have a higher line-height. We could also put everything on the same line and separate things with a dot symbol (• opt+8 on mac)

Please delete the account LankyBox01 from https://theforumhelpers.github.io/contributors/
It is my friend's account, i asked him to do stuff for me since i was too lazy to make my own github account.

Instead, use CodeGuy92, which is already on the list.

I was thinking that we would have a header with "The Forum Helpers", a small paragraph about us, and then a directory linking to different pages. For example, Forum Helpers and biographies, funny quotes/posts/topics, etc.

Thoughts?

Before going forward with the site overhaul, I was thinking that it would be a good idea to create new or update old issue templates, as well as create new pull request templates. This needs some discussion before I start to work on it.

For issue templates, I was thinking:
Bug Template
Assignees: Accio1
Labels: bug
Title: Bug:

Categories:

• Describe the bug
• Steps to reproduce
• How big of an impact does this have

Feature Template
Assignees: Accio1
Labels: enhancement, needs-discussion
Title: Feature Request:

Categories:

• Describe the feature in detail
• Why is this feature needed (If it is related to an issue, link the issue)
• Possible alternatives for this feature

Other Issue
Assignees: Accio1
Labels: none
Title: Other:

Categories:
none

And for pull request templates, I was thinking:
Feature Addition/Bug Fix Template
Categories:

• Describe what this PR adds/changes
• What issue was resolved? (Please don't submit major PRs unless they resolve an open issue)
• How was this tested?

Change To List of Forum Helpers Template

• What does this change? (Does it add a new Forum Helper? Does it change a biography? Does it promote a user from curator to manager?)
• Where did you get this change from? (If changing or adding a biography, link where the user requested the change/addition)

The problem with Pull Request Templates is that there is no way to add labels or titles or assignees to them like there is with issue templates. @leahcimto Would you be opposed to using Github Actions Labeler? https://github.com/actions/labeler to automatically label issues depending on what file was changed. I have tried it out on a private test repository and it seems to work as it should.

The credits area in the footer currently says "This website was made by -Accio- (Accio1 on Github) and NilsTheBest (NilsTheBest on Github) on behalf of the Forum Helpers", however, there are some other users who have helped this website, like the people in the forum helpers organization, and others who are not in that list.

✔️ MakeTheBrainHappy: https://scratch.mit.edu/users/makethebrainhappy/#comments-57937395
❓ BY147258369: https://scratch.mit.edu/users/BY147258369/#comments-57936161
✔️ XCat: https://scratch.mit.edu/users/XCat/#comments-57942234
✔️ awesome-llama: https://scratch.mit.edu/users/awesome-llama/#comments-57949407
✔️ cs156175: https://scratch.mit.edu/users/cs156175/#comments-57974701
✔️ Abstract-: https://scratch.mit.edu/users/Abstract-/#comments-58015302
✔️ BelieverGirlSun : https://scratch.mit.edu/users/BelieverGirlSun/#comments-57999925
✔️ rainpelt28: https://scratch.mit.edu/users/rainpelt28/#comments-58086506
✔️bbciplayer: https://scratch.mit.edu/users/bbciplayer/#comments-58125514
✔️ jakel181: https://scratch.mit.edu/users/jakel181/#comments-58148825
✔️YubNubEwok : https://scratch.mit.edu/users/YubNubEwok/#comments-58173151
✔️MaximunPokeMaster: https://scratch.mit.edu/users/MaximunPokeMaster/#comments-58460232
✔️jromagnoli: https://scratch.mit.edu/users/jromagnoli/#comments-58471815
✔️Add a note about customhacker being the founder of the studio.
✔️Botcho_Otkho: https://scratch.mit.edu/users/Botcho_Otkho/#comments-58733571
✔️(Changed to 1st person) bigpuppy: https://scratch.mit.edu/users/bigpuppy/#comments-58922596
✔️WolfCat67: https://scratch.mit.edu/users/WolfCat67/#comments-58935448
✔️joshuaho: https://scratch.mit.edu/users/joshuaho/#comments-59012008
✔️-Vuton-: https://scratch.mit.edu/users/-Vuton-/#comments-59099599
✔️DownsGameClub: https://scratch.mit.edu/users/DownsGameClub/#comments-59114580
✔️*Switch Flipped_ to Geonaut
✔️BlueStarPort: https://scratch.mit.edu/users/BlueStarPort/#comments-59407167
✔️54329: https://scratch.mit.edu/users/54329/#comments-59597282
✔️VideoGamerCanInvent: https://scratch.mit.edu/users/VideoGamerCanInvent/#comments-60374085
✔️Add WindOctahedron: https://scratch.mit.edu/users/WindOctahedron/#comments-60913804
✔️BGMead: https://scratch.mit.edu/users/BGMead/#comments-60950080
✔️Nambaseking01: https://scratch.mit.edu/studios/3688309/comments/#comments-67170234
✔️ConfusedBiscuit: https://scratch.mit.edu/studios/3688309/comments/#comments-67193306

Upon inspecting the list of Forum Helpers after #28 was merged, I noticed the following issues when the list of Forum Helpers was compared to the list of curators/managers in the studio.

• LegoManiac04 should come before Geonaut in the list of Forum Helpers
• awesome_guy_360 is missing (between jakel181 and orochi67). Looking through commit logs, it looks like they were simply missed in the original commit to add this list, and it hasn't been noticed since.
• nickeljorn is missing (between AfraidRacer and rainpelt28). Looking through commit logs, it looks like they weren't transferred when the site switched from biographies being coded directly to using JSON.
• bidulule is missing (between LuckyLucky7 and 54329). Looking through commit logs, it looks like they weren't transferred when the site switched from biographies being coded directly to using JSON.

This isn't SOO important but yeah, Byron's PFP is old.

Describe the bug
Pull request templates don't work

To Reproduce
Create a pull request, observe that there are no templates to choose from and no default template.

Expected behavior
There should be a selection of templates to choose from and they should have pre filled descriptions.

I notice a commit stating "rename quotes/ to Quotes/". It generally isn't aesthetically pleasing to use camelcase paths in URLs, nor to use underscores. I'd recommend renaming of all files back to lowercase, and using spaces (0x20 // %20) instead of underscores.

We can then address files at these locations via URI encoding (e.g. theforumhelpers/forum%20helpers/ for the folder "forum helpers".

Github Actions Labeller https://github.com/actions/labeler is a GitHub Action that will automatically label Pull Requests based on which files they change.

To do this, a workflow.yml file needs to be set up, as well as a labeler.yml file.

In the labeler.yml file, the following labels will be added to PRs based on what they change

• Any changes- unreviewed
• Changes to managers.json or curators.json- Forum Helpers List
• Changes to .github folder or README.md- documentation

Somewhat related to #54

Describe the changes needed
can i please have my status changed? i'd like it changed to "admin panel enthusiast" if thats okay.

Apply link class to change them to black.

Is your feature request related to a problem?
Yes. The problem is that the application process for the forum helper studio has changed a lot in the past few hours. The grading system was abolished, and other things are still being discussed. The front page should be updated to reflect the new changes.

Describe alternatives you've considered
Err.. not really any, as this fixes the front page showing false information.

Additional context
Labels: High-Prio, needs-discussion

CC: @Accio1

I have never seen an indentation style like this and it makes the CSS incredibly hard to read. In addition you use tabs (\t) for indentation globally. Can we agree on 2 characters or 4 characters of (space) rather than tabs for sake of ease of modification.

If you aren't already, install git locally and use git push to upload files modified locally using a sane text editor (I'd recommend Notepad++ for Windows).

I'm on a Mac at the moment (I usually use Windows, but today this due to personal reasons) and I don't know why but below the "This website was made by -Accio- (Accio1 on Github) and NilsTheBest (NilsTheBest on Github) on behalf of the Forum Helpers" text box there is a whole lot of unneeded white space. Can someone please fix that? Thanks!

A checkbox indicates a user has provided a bio.

Describe the changes needed
add the following people:

• ninjaMAR
• Futurebot5
• Steve0Greatness
• ScratchCatHELLO
• mybearworld
• Jeffalo
• dogsmakemehappy
• -EmeraldThunder-
• scratchykit5743
• 9gr
• Nezon

Additional context
ill do it soon

NOTE: If you are a user on this list please do provide a bio by replying to this issue.

Copy and paste message:

Hello! Congrats on getting accepted to TFH! If you don't mind, could you please provide a bio for our website? You can see some examples here: https://theforumhelpers.github.io/forumhelpers/ Please comment the bio you would like as well as your Scratch user id (find it at api.scratch.mit.edu/users/YOURUSERNAME/) on the following GitHub issue: #100 If you absolutely can't comment on GitHub, you may reply to this comment. Thanks!

👀 = i viewed

yo 100 issues/prs

Is your feature request related to a problem?
no, its a shefwerld-based forum helpers leaderboard

Describe alternatives you've considered
n/a this is my best api yet

Additional context
this - the current one i made, with the base from shefwerld

please can i be assigned

Describe the changes needed
add wangat to list bio pending

Additional context
no

The thing is, their account is deleted

That is why i made the repo.

I think that we should use Vercel for our pull requests, mainly for the preview option it offers. All that would need to be done would be to configure it to this repository here. After configuring it to this website, it will tell you to make a Vercel account, type the URL of this repository, and then finally deploy it. Then, whenever a pull request is submitted it will give you a link to the preview. This will help us avoid bugs and let us catch bugs before merging things into the master branch. Does anyone else think this would be a good idea?

https://scratch.mit.edu/studios/3688309/comments/#comments-133243932

Basic88
Nezon
moonliight--
NotDucki_
-InsanityGames-
bobcat0701
PoIygon
Steve0Greatness
-EmeraldThunder-
LankyBox01

Bios are pending for all users. I'll get them soon, and add these users to the list.

The List of Forum Helpers page contains information about the people who are currently Forum Helpers, but I feel as though it is lacking some features that could be beneficial.

• It would be neat to add different filters for sorting the list. For example, sorted by date joined (default used currently), or sorted alphabetically. I'm not sure how feasible this is based of of how the JSON is organised, but I will do some research to see if this is possible without creating an entirely separate JSON list that is sorted alphabetically.

• There should be a counter that shows the number of Forum Helpers, as well as how many curators and managers there are. This shouldn't be too difficult to implement.

• Not necessarily a feature, but the distinction between the curator and manager sections needs to be greater. Just scrolling, it is hard to tell where the list of managers ends and where the list of curators begins because the headings blend in with the rest of the content of the page.

• Integrate shefwrld/ocular/scratchDB to display post counts and other info next to user's names.

Describe the changes needed
What needs to be changed? Is it a bio, or do some users need to be added to the page? Please specify and include usernames and new bios if applicable. If a bio needs to be changed, but you are not the person who the bio belongs to, please provide a link to where that person asked for their bio to be changed.

Additional context
Add any other context about the change here.

It would be nice to have a 404 page for this site. I could work on this if that's ok with you (@Accio1).

Right now, the header and footer are embeds, meaning that it is very difficult to make changes to them or resize them, especially getting them to look good on a range of devices. Therefore, a better way to insert the header and footer into each page is needed. One way of doing this, which recently worked well for me on another site is by using JavaScript to insert the HTML directly into the page. The header and footer would be assigned as a variable in a JS file, which then would be loaded on each page and would insert the code into the corresponding part of the page. Since the code would then be a part of the page, it could easily be styled using CSS, and changing the JS file would change the header/footer for each page. This would allow issue #89 to be resolved, and would be a good step towards resolving #64

@leahcimto thoughts?

hello it's me business man jeffalo, i am here to suggest showing ocular status under bios on the user list.

Is your feature request related to a problem?
i like ocular status

Describe alternatives you've considered
n/a ocular is too original

Additional context
https://my-ocular.jeffalo.net/docs

In the curator/manager JSON, use null instead of "No biography provided" and add the "no biography provided" bit if its null into the JS script so we save a bit on size

if you guys want i can make a PR?

With the new application system, more users have been getting in a lot quicker, meaning that there are a few applicants that need to be added to the list:

A checkbox indicates that a bio was provided. Bios must be submitted before 4:00 PM EST today (Jan 23)

• dogsmakemehappy (id: 17609915)
• garnetluvcookie (id: 56239390)
• Jeffalo (id: 34018398)
• scratchykit5743 (id: 39136554)
• -Charon- (id: 41409105)
• ScratchCatHELLO (id: 25888082)
• chxrrycola-- (id: 70687323)
• mybearworld (id: 62325737)
• 9cjames1 (id: 26089328)

In progress (as of Jan 28, 7:16 PM EST)

Currently, this site uses a variety of CSS styles for its various parts. For example, different fonts, inconsistent CSS, etc.

In order to make the site more visually appealing, and make future development easier, the following need to be changed to make styles consistent across the site.

CSS Formating

• As often as possible, CSS should be located in sytlesheets, not as inline CSS.
  This keeps things neat and organized

• No duplicate CSS
  There should not be more than one line of CSS that does the same thing to the same class. Redundant CSS should be removed.

• CSS class names should follow a specific format:

page_description
Page should be the name of the page with the first letter lowercase. This is followed by an underscore and then a descriptive title of what the class refers to in lowercase

The following should be used as the page name for each class
Main page/homepage- home
List of Forum Helpers- forumhelpers
Header- nav
Footer- footer
Quotes- quotes
eg. home_title, forumhelpers_name, forumhelpers_bio, forumhelpers_pfp, nav_title, foot_link
- [ ] If a style is used throughout multiple pages (not in the header or footer), then the page name should be "all"

Do not change class or ID names for each block in the list of Forum Helpers page (Do not change FHP.js).

• Class vs ID
  Classes should be used to refer to an overall component that has one style. IDs should be used if changes are needed to specific parts of a class. Eg. If you had a group of boxes that look the same but are different colours, then all of the boxes would have the same class, which would determine shape, size, etc. IDs would be used to give the boxes different colours.

Styles

Fonts:

• Always use sans serif. Font families for text should be:
  Header: Montserrat, Arial, sans-serif. Montserrat should be obtained from Google Fonts here: https://fonts.google.com/specimen/Montserrat?category=Sans+Serif
  Page content: Arial, sans-serif

Colours

• Stick with the current colours
• Text should be black

Other Changes to Styling

• Try to get the headers on the list of Forum Helpers page to stand out more
• Change link styling (open for discussion @MTM828 feel free to talk about new link colours and transitions here!)

@leahcimto I know that you had expressed an interest in working on this. Do you still want to work on it?

Also, these changes still need discussion. The points above are just my ideas, feel free to suggest changes or improvements. Once we have a final copy, then this issue can start to be worked on.

Steps System

Step One: Rename all classes to match the format listed above
Step Two: Remove all inline CSS and convert it to CSS in a stylesheet
Step Three: Add additional CSS (eg. change fonts, etc.)
Step Four: Remove duplicate or unneeded CSS (This step will require extensive testing in order to make sure that no necessary CSS has been removed)

I think that our readme is pretty empty, and could use some more information, like who we are, a link to the studio, and how to join and contribute.