thefrontiergroup / frontier_generators Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 2.0 580 KB

Rails generators to be used to quickly scaffold CRUD for models in the Rails Template

Ruby 99.34% HTML 0.66%

frontier_generators's People

Contributors

Stargazers

Watchers

Forkers

jordanmaguire

frontier_generators's Issues

Add support for belongs_to as inline form

See: El Mulcho

extra comma on belongs_to association

The following yaml:

address:
  attributes:
    line_1:
      type: "string"
      validates:
        presence: true
    line_2:
      type: "string"
    suburb:
      type: "string"
      validates:
        presence: true
    postal_code:
      type: "string"
      validates:
        presence: true
    state:
      type: "belongs_to"
      validates:
        presence: true

Generated:

class Address < ActiveRecord::Base
  # Soft delete - uses deleted_at field
  acts_as_paranoid

  belongs_to :state,

  validates :line_1, presence: true
  validates :suburb, presence: true
  validates :postal_code, presence: true
  validates :state, presence: true

  def to_s
    line_1
  end

end

Didn't have enough time to look into that, but I think it's something to do in here: https://github.com/thefrontiergroup/frontier_generators/blob/master/lib/model_configuration/association.rb#L40

BTW, in newer versions of Rails, we do not need to do validates :state, presence: true, we can pretty much do belongs_to :state, required: true.

Thought about changing the generators to validates associations with require true.

Add specs for running the generators

Looks like https://github.com/stevehodgkiss/generator_spec should do the trick. Some brief testing has shown this should work.

Associations are gettting built as `f.association :thing_id` but should be `f.association :thing`

Add in support for `length:` validation

Add include_ui as the inverse of skip_ui

Use t.timestamps in migrations

"Delete" button should not show on index if delete action has been omitted

Use numericality validations to add min/max to inputs

EG:

= f.input :height_in_cm, input_html: {min: 0, max: 1}

I guess you'd need to add constants to the model and reference them:

# in model
HEIGHT_IN_CM_MIN = 0
HEIGHT_IN_CM_MAX = 1

Routes should react to skip_ui/include_ui options

EG:

resources :dongs, only: :index
resources :umbrellas, only: [:index, :show]

"New object" button should not show on index if new action has been omitted

migrations with timestamps are not specifying null: false

In rails 5 migrations with timestamps require null: false. See:

http://juanitofatas.com/2015/01/28/rails-5-timestamps/

Currently the generators can't do this. There is currently no way to specify null constraints from the command line.

Add `autofocus: true` to primary attribute on form

= f.input :given_names, autofocus: true

When adding numericality validations ensure that rand call in factory respects these values

Add CanCan adaptor layer so that either Pundit or CanCan can be specified

PS:

Fuck pundit

YOLO

Form for associations should show `f.association :association`

Feature specs don't take namespaces into account

Always creates using admin namespace

Form generation for associations is broken.

interview_questionnaire:
  namespaces: ["member"]
  skip_seeds: true
  attributes:
    address:
      show_on_index: false
      type: belongs_to

generates..

= simple_form_for [:member, @interview_questionnaire], wrapper: "horizontal", html: {class: "form-horizontal"} do |f|
  = f.association :address_id, collection: Address.all
  .form-actions
    = f.button :submit
    %span.or or
    = link_to "Cancel", member_interview_questionnaires_path

instead of

= simple_form_for [:member, @interview_questionnaire], wrapper: "horizontal", html: {class: "form-horizontal"} do |f|
  = f.association :address, collection: Address.all
  .form-actions
    = f.button :submit
    %span.or or
    = link_to "Cancel", member_interview_questionnaires_path

Add null: false to migrations with presence: true validations

If I define an attribute has having presence: true, it would be great if the migration could automatically add null: false to the column.

Move shared example block out into shared group

  shared_examples_for "Policy without access to CRUD actions" do
    it { should_not permit_access_to(:index) }
    it { should_not permit_access_to(:new) }
    it { should_not permit_access_to(:create) }
    it { should_not permit_access_to(:edit) }
    it { should_not permit_access_to(:update) }
    it { should_not permit_access_to(:destroy) }
  end

RSpec unit tests of scaffold functionality

Generate sidebar link for menu options

It's time to make this map pretty hard to the rails template so that we can save more time.

Add option include_sidebar_link that defaults to true to support this implementation.

Use dependent: destroy on associations

Probably as an option. (Default: off)

Can set primary attribute, that is used as #to_s and instead of attributes.first

Migrations for attributes with different class names are broken

interview_questionnaire:
  namespaces: ["member"]
  skip_seeds: true
  attributes:
    gp_address:
      show_on_index: false
      type: belongs_to
      class_name: "Address"

will generate the following migration

class CreateInterviewQuestionnaire < ActiveRecord::Migration
  def change
    create_table :interview_questionnaires do |t|
      t.belongs_to :gp_address, index: true, foreign_key: true
      t.datetime :created_at
      t.datetime :updated_at
      t.datetime :deleted_at
    end
    add_index :interview_questionnaires, :deleted_at
  end
end

This will fail PGError: ERROR: relation “gp_address” does not exist. The migration requires a 'references' component, which you can't use foreign_key: true on :/. Migration should end up looking like this for it to work.

class CreateInterviewQuestionnaire < ActiveRecord::Migration
  def change
    create_table :interview_questionnaires do |t|
      t.belongs_to :gp_address, references: :addresses, index: true
      t.datetime :created_at
      t.datetime :updated_at
      t.datetime :deleted_at
    end
    add_index :interview_questionnaires, :deleted_at
    add_foreign_key :interview_questionnaires, :addresses, column: :gp_address_id
  end
end

skip_ui: true

# or

skip_ui:
  skip_index: true
  skip_new: true
  skip_edit: true

# or

skip_ui: [:index, :new, :edit]

Add `belongs_to :association, required: true`

Add default_controller_sort_order

this should apply to controllers:

protected

  # Override: Admin::BaseController
  def default_sort_options
    {created_at: :desc}
  end

thefrontiergroup/rails-template#73

thefrontiergroup / frontier_generators Goto Github PK

frontier_generators's People

Contributors

Stargazers

Watchers

Forkers

frontier_generators's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs