thekewlstore / minescape Goto Github PK

The Toast notification bar can get really cluttered at high digging levels because of the amount of drops. To combat this, drops of the same item type should be combined into one gui and the quantity updated to reduce the amount of toasts shown at a time.

Experience lamps come in two variants, one allowing you to choose a skill to gain xp in, and one attuned to a specific skill.

XP Rewards are currently planned to be equal to 12,500 at 99.

• Ability to dig vertical chains of sand and gravel all at once
• Tool Restrictions

Want to add a GUI to the skills tab that will display information on level up milestones and effects gained at different levels.

The progress bar HUD is basing it's progress on the progress from level 1 to the next level, rather from the previous level to the next.

Standardize the handling of Level up and XP Gained events via the ISkill interface and BasicSkill implementation.

Proposed change:
The ISkill interface gains an overloaded gainXP method with an EntityPlayer parameter which is necessary to link to the XP Gained and level up events when posting the event bus.

• Scaling Attack Speed
• Scaling Attack Damage
• Double Loot from monsters
• Rarer Drops from monsters (possibly based on sword as well)
• Restrictions to tools
• Support for Tinkers tools

The level up handler currently sets the ISkill implementation on the client-side to the level specified in the message. This can cause undesired behavior as it can increase or decrease the amount of experience the user actually gained because the underlying implementation essentially sets the current xp equal to the minimum requirement for that level. The level up handler should not have to update the skill implementation's data at all as all level events should be accompanied with an xp gained event. Therefore, the xp will be set to the correct value and the level up handler should strictly display the toast message.

A binary search tree implementation of looking up xp to level mappings will be imperative for performance of the skilling system.

As defined in the Digging Skill outline, breaking blocks at certain levels of digging should give a chance at drops from a rare loot table, with chances based on the tool used and level in digging.

When a player reaches 99 with a full inventory, they do not get their skill cape. It should be dropped on the ground instead.

The skills tab needs to be added to the creative inventory screen.
This suggests a restructure of the MenuInterfaceOverride class (which needs to be renamed as well)
in order to work both for GuiInventoryCreative and GuiInventory.

Not sure how this will be achieved yet.